Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: update mirror argument from "position" to "origin" #4714

Closed
wants to merge 5 commits into from
Closed

REFACTOR: update mirror argument from "position" to "origin" #4714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cd6ab9e
Update mirror in components_3d.py
marcobiasizzo May 22, 2024
067aaf7
Update mirror in object3d.py
marcobiasizzo May 22, 2024
c65e21e
Update mirror components_3d.py
marcobiasizzo May 22, 2024
2eacd0a
Update object3d.py
marcobiasizzo May 22, 2024
b333f1d
Merge branch 'main' into main
MaxJPRey May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pyaedt/modeler/cad/components_3d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,13 +510,13 @@ def duplicate_and_mirror(self, origin, vector):
"""
return self._primitives.duplicate_and_mirror(self.name, origin=origin, vector=vector, is_3d_comp=True)

@pyaedt_function_handler()
def mirror(self, position, vector):
@pyaedt_function_handler(position="origin")
def mirror(self, origin, vector):
"""Mirror a selection.

Parameters
----------
position : list, Position
origin : list, Position
List of the ``[x, y, z]`` coordinates or
the Application.Position object for the selection.
vector : float
Expand All @@ -534,11 +534,11 @@ def mirror(self, position, vector):
>>> oEditor.Mirror
"""
if self.is3dcomponent:
if self._primitives.mirror(self.name, position=position, vector=vector):
if self._primitives.mirror(self.name, origin=origin, vector=vector):
return self
else:
for part in self.parts:
self._primitives.mirror(part, position=position, vector=vector)
self._primitives.mirror(part, origin=origin, vector=vector)
return self
return False

Expand Down
8 changes: 4 additions & 4 deletions pyaedt/modeler/cad/object3d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1450,13 +1450,13 @@ def split(self, plane, sides="Both"):
"""
return self._primitives.split(self.name, plane, sides)

@pyaedt_function_handler()
def mirror(self, position, vector, duplicate=False):
@pyaedt_function_handler(position="origin")
def mirror(self, origin, vector, duplicate=False):
"""Mirror a selection.

Parameters
----------
position : list of int or float
origin : list of int or float
Cartesian ``[x, y, z]`` coordinates or
the ``Application.Position`` object of a point in the plane used for the mirror operation.
vector : list of float
Expand All @@ -1477,7 +1477,7 @@ def mirror(self, position, vector, duplicate=False):

>>> oEditor.Mirror
"""
if self._primitives.mirror(self.id, position=position, vector=vector, duplicate=duplicate):
if self._primitives.mirror(self.id, origin=origin, vector=vector, duplicate=duplicate):
return self
return False

Expand Down
Loading