Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: Update readme #4709

Merged
merged 4 commits into from
May 22, 2024
Merged

Conversation

Devin-Crawford
Copy link
Contributor

Minor changes to README.md
Added a note about the sematic PR convention.

Minor changes to README.md
Added a note about the sematic PR convention.
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

README.md Outdated Show resolved Hide resolved
MaxJPRey
MaxJPRey previously approved these changes May 21, 2024
Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding it to the doc @dcrawforAtAnsys !

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.31%. Comparing base (fa00714) to head (a1fb718).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4709      +/-   ##
==========================================
- Coverage   80.48%   79.31%   -1.18%     
==========================================
  Files         122      122              
  Lines       54964    54964              
==========================================
- Hits        44240    43592     -648     
- Misses      10724    11372     +648     

Co-authored-by: Maxime Rey <[email protected]>
@maxcapodi78 maxcapodi78 enabled auto-merge (squash) May 21, 2024 19:29
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
PipKat
PipKat previously approved these changes May 21, 2024
Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits suggeted. Great job!

Add suggestions from @PipKat

Co-authored-by: Kathy Pippert <[email protected]>
Add hyperlink to commit-style.
@Devin-Crawford Devin-Crawford requested review from PipKat and MaxJPRey and removed request for PipKat, MaxJPRey and SMoraisAnsys May 22, 2024 06:40
@Devin-Crawford
Copy link
Contributor Author

@Suggestions were added along with a link to the commit-style actions yaml in the README.md.

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this information

@maxcapodi78 maxcapodi78 merged commit 4767a90 into main May 22, 2024
33 checks passed
@maxcapodi78 maxcapodi78 deleted the 4703-add-semantic-naming-to-the-readmemd branch May 22, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add semantic naming conventions or a corresponding hyperlink to the README.md
6 participants