FIX: Function handler to return False #4706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following my request changes in #4463, it seems that the pyaedt_function_handler function was not working correctly. Indeed, if an exception was raised and the settings were such that one would want the function handler to return False, no value was returned by the function (leading to a None return).
Different behaviors of the function handler are tests: - enable error handler - release on exception - argument deprecation mechanism
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4706 +/- ##
=======================================
Coverage 80.48% 80.49%
=======================================
Files 122 122
Lines 54964 54964
=======================================
+ Hits 44240 44242 +2
+ Misses 10724 10722 -2 |
MaxJPRey
reviewed
May 21, 2024
MaxJPRey
reviewed
May 21, 2024
PipKat
reviewed
May 21, 2024
Co-authored-by: Kathy Pippert <[email protected]>
maxcapodi78
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #4463, it seems that the
pyaedt_function_handlerfunction was not working correctly. Indeed, if an exception was raised and the settings were such that one would want the function handler to return False, no value was returned by the function (leading to a None return).Some tests have been added to ensure that the behavior of the function does not changes without notice. They cover the following behaviors of the function handler:
Closes #4707