-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHORE: Update matplotlib requirement from <3.9,>=3.5.0 to >=3.5.0,<3.10 #4686
Conversation
Updates the requirements on [matplotlib](https://github.com/matplotlib/matplotlib) to permit the latest version. - [Release notes](https://github.com/matplotlib/matplotlib/releases) - [Commits](matplotlib/matplotlib@v3.5.0...v3.9.0) --- updated-dependencies: - dependency-name: matplotlib dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4686 +/- ##
==========================================
- Coverage 80.33% 74.19% -6.14%
==========================================
Files 120 121 +1
Lines 55076 55136 +60
==========================================
- Hits 44245 40908 -3337
- Misses 10831 14228 +3397 |
40451db
@SMoraisAnsys There is a problem with matplotlib and numpy versions and python version. I have updated the numpy version and the unit tests now passes, I realized last matplotlib need numpy 1.23, and PyAEDT was 1.20: https://github.com/matplotlib/matplotlib/blob/main/pyproject.toml But I think we have to add the last compatible 3.7 version, and maybe also 3.8. Please could you check it? |
I'll do that after finishing checking the documentation errors |
@Samuelopez-ansys As far as I know, we don't require to upgrade numpy version. If you install pyaedt with a recent CPython version (>= 3.10) you'll end up installing a version that is higher than 1.23 any way (when testing I ended up installing version 1.26.Z) |
An idea as of to why the tests are not passing : are we sure that the passed data is coherent (no None values among floats or things like that) ? From what I can see in the matplotlib release note, we shouldn't be impacted as we are right now. |
@SMoraisAnsys Not sure... I can not reproduce it locally, maybe it is related to this: https://github.com/matplotlib/matplotlib/issues?q=is%3Aissue+PyCapsule_New+is%3Aclosed |
A newer version of matplotlib exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
@dependabot recreate |
Superseded by #4894. |
Updates the requirements on matplotlib to permit the latest version.
Release notes
Sourced from matplotlib's releases.
Commits
be56634
REL: v3.9.0846ce8a
DOC: Finish documentation for 3.9.08604f67
Merge pull request #28206 from meeseeksmachine/auto-backport-of-pr-28205-on-v...196c8db
TST: Followup corrections to #28205d8f3016
Backport PR #28205: TST: Fix tests with older versions of ipython4db5ac9
Merge pull request #28203 from QuLogic/auto-backport-of-pr-28164-on-v3.9.xef1a2db
Merge pull request #28204 from meeseeksmachine/auto-backport-of-pr-28195-on-v...e4384b8
Merge pull request #28191 from QuLogic/no-dev-theme3b65546
Backport PR #28195: TST: Prepare for pytest 91b526c3
Backport PR #28164: CI: Ensure code coverage is always uploadedYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)