Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: improved the way wires are mapped and managed in Circuit #4679

Merged
merged 3 commits into from
May 17, 2024

Conversation

maxcapodi78
Copy link
Collaborator

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the maintenance Package and maintenance related label May 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

Attention: Patch coverage is 89.79592% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 80.60%. Comparing base (b8801e2) to head (d8a618d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4679      +/-   ##
==========================================
- Coverage   80.62%   80.60%   -0.02%     
==========================================
  Files         121      121              
  Lines       54826    54855      +29     
==========================================
+ Hits        44201    44218      +17     
- Misses      10625    10637      +12     

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) May 17, 2024 10:10
@Samuelopez-ansys Samuelopez-ansys merged commit 3284944 into main May 17, 2024
33 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the circuit_wire_improvements branch May 17, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants