Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Transient ambient temperature in design settings & Design settings class #4580

Merged
merged 28 commits into from
May 2, 2024
Merged

FEAT: Transient ambient temperature in design settings & Design settings class #4580

merged 28 commits into from
May 2, 2024

Conversation

lorenzovecchietti
Copy link
Contributor

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.51724% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 81.50%. Comparing base (7c3be01) to head (58d607d).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4580   +/-   ##
=======================================
  Coverage   81.49%   81.50%           
=======================================
  Files         110      110           
  Lines       53840    53887   +47     
=======================================
+ Hits        43876    43919   +43     
- Misses       9964     9968    +4

@lorenzovecchietti lorenzovecchietti changed the title Transient ambient temperature in design settings & Design settings class FEAT: Transient ambient temperature in design settings & Design settings class Apr 26, 2024
@lorenzovecchietti lorenzovecchietti marked this pull request as ready for review April 29, 2024 09:39
@lorenzovecchietti lorenzovecchietti marked this pull request as draft April 29, 2024 09:39
@lorenzovecchietti lorenzovecchietti marked this pull request as ready for review April 29, 2024 14:41
PipKat
PipKat reviewed Apr 30, 2024
View reviewed changes
pyaedt/icepak.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Apr 30, 2024
View reviewed changes
pyaedt/icepak.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Apr 30, 2024
View reviewed changes
pyaedt/icepak.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Apr 30, 2024
View reviewed changes
pyaedt/icepak.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Apr 30, 2024
View reviewed changes
pyaedt/icepak.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Apr 30, 2024
View reviewed changes
pyaedt/icepak.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Apr 30, 2024
View reviewed changes
pyaedt/icepak.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Apr 30, 2024
View reviewed changes
pyaedt/icepak.py Outdated Show resolved Hide resolved
SMoraisAnsys
SMoraisAnsys requested changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a tiny mistake when manipulate_inputs is None be default.
I also left a couple of comments, LGTM otherwise !

pyaedt/application/Design.py Outdated Show resolved Hide resolved
pyaedt/icepak.py Outdated Show resolved Hide resolved
pyaedt/application/Design.py Outdated Show resolved Hide resolved
pyaedt/icepak.py Outdated Show resolved Hide resolved
@lorenzovecchietti lorenzovecchietti marked this pull request as draft May 2, 2024 07:21
@lorenzovecchietti lorenzovecchietti mentioned this pull request May 2, 2024
Merged
@lorenzovecchietti lorenzovecchietti marked this pull request as ready for review May 2, 2024 10:03
@lorenzovecchietti lorenzovecchietti merged commit 4adad01 into main May 2, 2024
15 checks passed
@lorenzovecchietti lorenzovecchietti deleted the transient_ambient_temperature branch May 2, 2024 12:55
@SMoraisAnsys SMoraisAnsys mentioned this pull request May 3, 2024
Closed
@lorenzovecchietti lorenzovecchietti mentioned this pull request May 3, 2024
Closed
2 tasks
SMoraisAnsys added a commit to ansys/pyaedt-examples that referenced this pull request May 3, 2024
@SMoraisAnsys
FIX: Example Q2D_Armoured_Cable
168f6c9 
Update example following ansys/pyaedt#4580
@SMoraisAnsys SMoraisAnsys mentioned this pull request May 3, 2024
Merged
lorenzovecchietti pushed a commit to ansys/pyaedt-examples that referenced this pull request May 3, 2024
@SMoraisAnsys
FIX: Example Q2D_Armoured_Cable (#118)
f0ea724 
Update example following ansys/pyaedt#4580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PipKat PipKat PipKat left review comments

@SMoraisAnsys SMoraisAnsys SMoraisAnsys approved these changes

@Samuelopez-ansys Samuelopez-ansys Awaiting requested review from Samuelopez-ansys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lorenzovecchietti @codecov-commenter @PipKat @SMoraisAnsys