Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACT: Clean up variables.py file #4554

Merged
merged 5 commits into from
Apr 24, 2024
Merged

Conversation

SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys commented Apr 19, 2024

As title says.

Related to #4552

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@SMoraisAnsys SMoraisAnsys self-assigned this Apr 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 39.28571% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 81.51%. Comparing base (d1a2049) to head (424ea97).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4554       +/-   ##
===========================================
+ Coverage   34.39%   81.51%   +47.11%     
===========================================
  Files         110      110               
  Lines       53753    53765       +12     
===========================================
+ Hits        18487    43824    +25337     
+ Misses      35266     9941    -25325     

Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SMoraisAnsys for the refactoring!

@SMoraisAnsys SMoraisAnsys merged commit c4b109d into main Apr 24, 2024
15 checks passed
@SMoraisAnsys SMoraisAnsys deleted the refact/clean-variables branch April 24, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants