Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix touchstone deepcopy issue #3892

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Fix touchstone deepcopy issue #3892

merged 2 commits into from
Nov 21, 2023

Conversation

Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented Nov 21, 2023 •
edited
Loading

Close #3883

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@Samuelopez-ansys
Copy link
Member Author

@ansys-reviewer-bot review

@ansys-reviewer-bot
Copy link
Contributor

Okay, I will trigger a review of your PR.

@github-actions github-actions bot added the bug Something isn't working label Nov 21, 2023
hui-zhou-a
hui-zhou-a approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@hui-zhou-a hui-zhou-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov Codecov
Copy link

codecov bot commented Nov 21, 2023 •
edited
Loading

Codecov Report

Merging #3892 (31e3fc3) into main (ae2591a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3892   +/-   ##
=======================================
  Coverage   81.30%   81.30%           
=======================================
  Files         182      182           
  Lines       62825    62825           
=======================================
+ Hits        51077    51079    +2     
+ Misses      11748    11746    -2

Alberto-DM
Alberto-DM approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@Alberto-DM Alberto-DM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys
Copy link
Member Author

@Alberto-DM You were right, with a shallow copy it works. The method is just reordering some Network data, and it does not modify the solution_data, so I prefer this solution. Let me know if you see anything strange before merging.

@Samuelopez-ansys Samuelopez-ansys merged commit 611651b into main Nov 21, 2023
@Samuelopez-ansys Samuelopez-ansys deleted the fix/issue_3883 branch November 21, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansys-reviewer-bot ansys-reviewer-bot[bot] ansys-reviewer-bot[bot] left review comments

@hui-zhou-a hui-zhou-a hui-zhou-a approved these changes

@Alberto-DM Alberto-DM Alberto-DM approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug located in touchstone_parser
3 participants
@Samuelopez-ansys @hui-zhou-a @Alberto-DM