Skip to content

Commit

Permalink
Create port on pin name selection adjustment (#4061)
Browse files Browse the repository at this point in the history
* edb intersection bug fix

* component.is_top property added
  • Loading branch information
svandenb-dev authored Jan 12, 2024
1 parent 66e568d commit ab3443b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
8 changes: 6 additions & 2 deletions pyaedt/edb_core/components.py
Original file line number Diff line number Diff line change
Expand Up @@ -765,7 +765,9 @@ def create_port_on_pins(self, refdes, pins, reference_pins, impedance=50.0, port
if len([pin for pin in pins if isinstance(pin, str)]) == len(pins):
cmp_pins = []
for pin_name in pins:
cmp_pin = [pin for pin in list(refdes.pins.values()) if pin_name in pin.name]
cmp_pin = [pin for pin in list(refdes.pins.values()) if pin_name == pin.name]
if not cmp_pin:
cmp_pin = [pin for pin in list(refdes.pins.values()) if pin_name == pin.name.split("-")[1]]
if cmp_pin:
cmp_pins.append(cmp_pin[0])
if not cmp_pins:
Expand All @@ -779,7 +781,9 @@ def create_port_on_pins(self, refdes, pins, reference_pins, impedance=50.0, port
if len([pin for pin in reference_pins if isinstance(pin, str)]) == len(reference_pins):
ref_cmp_pins = []
for ref_pin_name in reference_pins:
cmp_ref_pin = [pin for pin in list(refdes.pins.values()) if ref_pin_name in pin.name]
cmp_ref_pin = [pin for pin in list(refdes.pins.values()) if ref_pin_name == pin.name]
if not cmp_ref_pin:
cmp_ref_pin = [pin for pin in list(refdes.pins.values()) if ref_pin_name == pin.name.split("-")[1]]
if cmp_ref_pin:
ref_cmp_pins.append(cmp_ref_pin[0])
if not ref_cmp_pins:
Expand Down
1 change: 1 addition & 0 deletions pyaedt/modules/SolveSetup.py
Original file line number Diff line number Diff line change
Expand Up @@ -1807,6 +1807,7 @@ def export_to_hfss(self, file_fullname, keep_net_name=False):
def _get_net_names(self, app, file_fullname):
primitives_3d_pts_per_nets = self._get_primitives_points_per_net()
via_per_nets = self._get_via_position_per_net()
pass
layers_elevation = {
lay.name: lay.lower_elevation + lay.thickness / 2
for lay in list(self.p_app.modeler.edb.stackup.signal_layers.values())
Expand Down

0 comments on commit ab3443b

Please sign in to comment.