add 'extraDeploy' value to Helm Chart to allow deploying additional r…

[justsomescripts]

SUMMARY

This PR allows deploying additional resources in the cluster when using the Helm Chart. Resources are defined as an array (either directly in YAML or using literal "|"). That makes it easier to deploy additional objects that are used by AWX, e.g. using ExternalSecrets to create secrets required by AWX, which currently requires manual deployments or using an own Helm Chart.

ISSUE TYPE

• New or Enhanced Feature

ADDITIONAL INFORMATION

The resources are passed trough tpl, so Helm templating is possible. This feature is also common in other Charts as well, e.g. Bitnami Helm Charts

Example usage

AWX:
  # enable use of awx-deploy template
  ...

  # configurations for external postgres instance
  postgres:
    enabled: false
    ...

extraDeploy:
  - |
    apiVersion: external-secrets.io/v1beta1
    kind: ExternalSecret
    metadata:
      name: {{ .Release.Name }}-postgres-secret-string-example
      namespace: {{ .Release.Namespace }}
      labels:
        app: {{ .Release.Name }}
    spec:
      secretStoreRef:
        name: vault
        kind: ClusterSecretStore
      refreshInterval: "1h"
      target:
        name: postgres-configuration-secret-string-example
        creationPolicy: "Owner"
        deletionPolicy: "Delete"
      dataFrom:
        - extract:
            key: awx/postgres-configuration-secret

  - apiVersion: external-secrets.io/v1beta1
    kind: ExternalSecret
    metadata:
      name: "{{ .Release.Name }}-postgres-secret-yaml-example"
      namespace: "{{ .Release.Namespace }}"
      labels:
        app: "{{ .Release.Name }}"
    spec:
      secretStoreRef:
        name: vault
        kind: ClusterSecretStore
      refreshInterval: "1h"
      target:
        name: postgres-configuration-secret-yaml-example
        creationPolicy: "Owner"
        deletionPolicy: "Delete"
      dataFrom:
        - extract:
            key: awx/postgres-configuration-secret

[rooftopcellist]

cc @miles-w-3 for awareness and review

[miles-w-3]

It's a nice way to avoid needing to downstream/wrap the chart in order to deploy additional resources, cool. Tpl is super powerful because It basically allows the chart to deploy anything. Not too many charts do this but I don't see a problem with it.

Once thing you may want to consider for the yaml case is piping to nindent 0 and chomping the new line at the start, I've found that can be helpful for ensuring whitespace works

[justsomescripts]

Once thing you may want to consider for the yaml case is piping to nindent 0 and chomping the new line at the start, I've found that can be helpful for ensuring whitespace works

Could you provide an example to help clarify? I've tried various definitions using different spacing, but I haven't been able to create an incorrect or problematic YAML.

[TheRealHaoLiu]

@justsomescripts can you put the example that you have in the issue into the doc?

if @miles-w-3 agree with the approach (please indicate via an approval) than we will go ahead and merge this PR

[justsomescripts]

@justsomescripts can you put the example that you have in the issue into the doc?

@TheRealHaoLiu sure, I updated the PR.

[miles-w-3]

Sorry for the delay @justsomescripts, I added an example in a comment. It will also help you clean up the indentation without having to tab inside your {{