Omit storage limit when empty #1635
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: register instance after creation dependent on API/CLI change
sample are used in CI for validation test in current implementation we only support openshift route this will not work on kind clusters correctly and having the sample is causing CI failure
The mesh role now calls 1. awx-manage provision instance to register the hop node to the database 2. awx-manage add_receptor_address to register the internal address 3. awx-manage add_receptor_address to register the external address (to be used by remote nodes) CRD expanded to include external_ipaddress and external_hostname external_ipaddress is added as ipaddress in the hop node certificate external_hostname is added as dnsname in the hop node certificate the mesh role now checks for is_openshift and only creates a Route if true. Otherwise it will use external_hostname set in the spec file in place of Route name. Signed-off-by: Seth Foster <[email protected]>
When pod loses connection with k8s api server, a statefulset can take a while (5 minutes) before it is rescheduled. Deployments quicker turnaround in this situation, which should help mesh stability. Signed-off-by: Seth Foster <[email protected]>
- add --is_internal and --peers_from_control_nodes to indicate the address is internal Signed-off-by: Seth Foster <[email protected]>
This way when AWX is deleted associated AWXMeshIngress will all be deleted as well
external_ipaddress is optional and we should be able to deal with missing external_ipaddress with no error
We discovered some weird behavior observed on later Kubernetes version (OCP 4.12+)
For some reason why we apply the templates postgres resource with
```
postgres_storage_requirements:
limit: {}
requests:
storage: <x>Gi
```
the `Create Database if no database is specified` task that does the k8s apply will always think the resource is "changed" and proceed to cycle the task and web pod
This resulted in AWX pods being continuously restarted
|
wrong base branch closing in favor of #1637 |
|
Closing in favor of #1637, which has already merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We discovered some weird behavior observed on later Kubernetes version (OCP 4.12+)
For some reason why we apply the templates postgres resource with
the
Create Database if no database is specifiedtask that does the k8s apply will always think the resource is "changed" and proceed to cycle the task and web podThis resulted in AWX pods being continuously restarted
ISSUE TYPE
ADDITIONAL INFORMATION