[WIP] rule to check changelog most recent version with galaxy version in galaxy.yml #3872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KB-perByte
requested review from
a team,
priyamsahoo and
shatakshiiii
and removed request for
a team
KB-perByte
changed the title
KB-perByte
commented
Jan 26, 2024
| } | ||
|
|
||
| def matchplay(self, file: Lintable, data: dict[str, Any]) -> list[MatchError]: | ||
| """Return matches found for a specific play (entry in playbook).""" | ||
| changelog_file_data = [] | ||
| global CHANGELOG_FILE |
There was a problem hiding this comment.
Not fond of this implementation, reusing the file object to read changelog data and compare it to galaxy is a better implementation.
audgirka
force-pushed
the
galaxy_version_changelog
branch
from
759c0f2 to
efcbac9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rule to check changelog most recent version with galaxy version in galaxy.yml