Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for Mac OS #3825

Closed
wants to merge 10 commits into from
Closed

Fix tests for Mac OS #3825

wants to merge 10 commits into from

Conversation

audgirka
Copy link
Contributor

@audgirka audgirka commented Oct 9, 2023 •
edited
Loading

Since options.lintables contained a path to the yaml file from an earlier test, we were
unable to search for all the lintables correctly.
Setting it to an empty list fixes this issue.

#3815 can be merged after this

@audgirka audgirka requested a review from a team as a code owner October 9, 2023 10:32
@audgirka audgirka requested review from a team, cristianonicolai, Qalthos and Ruchip16 October 9, 2023 10:32
@audgirka audgirka temporarily deployed to ack October 9, 2023 10:32 — with GitHub Actions Inactive
@audgirka audgirka temporarily deployed to ack October 9, 2023 10:33 — with GitHub Actions Inactive
@audgirka audgirka mentioned this pull request Oct 9, 2023
Merged
@audgirka audgirka temporarily deployed to ack October 9, 2023 10:49 — with GitHub Actions Inactive
@audgirka audgirka added the skip-changelog Can be missed from the changelog. label Oct 9, 2023
@audgirka audgirka temporarily deployed to ack October 9, 2023 11:06 — with GitHub Actions Inactive
@ssbarnea ssbarnea temporarily deployed to ack October 9, 2023 11:50 — with GitHub Actions Inactive
ssbarnea
ssbarnea requested changes Oct 9, 2023
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking it until we refactor the broken code. I am working on it and checked with @cidrblock

@ssbarnea ssbarnea mentioned this pull request Oct 10, 2023
Merged
@audgirka audgirka reopened this Oct 10, 2023
@audgirka audgirka temporarily deployed to ack October 10, 2023 10:50 — with GitHub Actions Inactive
@audgirka audgirka temporarily deployed to ack October 10, 2023 11:06 — with GitHub Actions Inactive
@ssbarnea
Copy link
Member

No longer needed.

@ssbarnea ssbarnea closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea requested changes

@priyamsahoo priyamsahoo priyamsahoo approved these changes

@cristianonicolai cristianonicolai Awaiting requested review from cristianonicolai cristianonicolai is a code owner automatically assigned from ansible/devtools

@Qalthos Qalthos Awaiting requested review from Qalthos Qalthos is a code owner automatically assigned from ansible/devtools

@Ruchip16 Ruchip16 Awaiting requested review from Ruchip16 Ruchip16 is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
skip-changelog Can be missed from the changelog.
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@audgirka @ssbarnea @priyamsahoo