Fix use of versioned github action

[karl-johan-grahn]

The README would need to be updated too because tagging the GitHub action runner won't work for earlier versions that this PR will eventually be part of - earlier versions will always use main. Updating the README has to be done after this PR has been merged though, since we don't know the version this fix will be part of.

Fixes: #3761
Related: https://github.com/orgs/community/discussions/49245
Related: actions/runner#2473

[ChristopherHX]

@karl-johan-grahn I assume this works now, if you reference the action via uses: ansible/ansible-lint@<tag> (refs/pull/3762/head doesn't work)
I'm just a random GitHub user and commented here, because this change has been mentioned in a subscribed actions/runner issue.

You need a reviewer from this project, I can't help you with that.

Seems like if action_ref is refs/pull/3762/head the wget breaks, but I'm probably only one of a very small amount of people trying very exotic action versions.

[karl-johan-grahn]

@ssbarnea please review and any plans to merge this soon? 🙇

[karl-johan-grahn]

@ajinkyau @priyamsahoo @ChristopherHX @shatakshiiii @ssbarnea any possibility to merge this soon?

[ChristopherHX]

Please look at actions/runner#2473 (comment), there is another defect in actions/runner. Only appears if you nest composite actions.

FYI It is possible to add version information into the downloaded zip (act won't be compatible with that) like done here: psf/black#3543

[karl-johan-grahn]

Is the action nested for this repo's workflow?

[ChristopherHX]

Is the action nested for this repo's workflow?

No, but the user can use the action in their own composite action and hit the problem.

E.g.

runs:
  using: composite
  steps:
  - uses: ansible/[email protected]

Will not get v6.21.1, but the tag of the action.yml posted above.

[karl-johan-grahn]

At least it will be one step better than now