Skip to content

Commit

Permalink
Add win_command/win_shell to no-free-form modules (#2596)
Browse files Browse the repository at this point in the history
* Add FQCN versions of tasks to match list

* Add win_command/win_shell to no-free-form modules

These modules should be treated similarly to their Unix counterparts.
  • Loading branch information
nre-ableton authored Oct 13, 2022
1 parent 3a9e290 commit 644553e
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/ansiblelint/rules/no_free_form.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,14 @@ def matchtask(
elif isinstance(action_value, str) and "=" in action_value:
fail = False
if task["action"].get("__ansible_module__") in (
"ansible.builtin.command",
"ansible.builtin.shell",
"ansible.windows.win_command",
"ansible.windows.win_shell",
"command",
"shell",
"win_command",
"win_shell",
):
if self.cmd_shell_re.match(action_value):
fail = True
Expand Down

0 comments on commit 644553e

Please sign in to comment.