Update linters (#3821)

.pre-commit-config.yaml

@@ -101,7 +101,7 @@ repos:
       - id: debug-statements
         language_version: python3
   - repo: https://github.com/codespell-project/codespell
-    rev: v2.2.5
+    rev: v2.2.6
     hooks:
       - id: codespell
         exclude: >
@@ -130,7 +130,7 @@ repos:
         types: [file, yaml]
         entry: yamllint --strict
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: "v0.0.291"
+    rev: "v0.0.292"
     hooks:
       - id: ruff
         args: [--fix, --exit-non-zero-on-fix]
@@ -169,7 +169,7 @@ repos:
             plugins/.*
           )$
   - repo: https://github.com/pycqa/pylint
-    rev: v3.0.0b0
+    rev: v3.0.1
     hooks:
       - id: pylint
         args:

pyproject.toml

@@ -160,6 +160,9 @@ enable = [
   "useless-suppression", # Identify unneeded pylint disable statements
 ]
 
+[tool.pylint.REPORTING]
+output-format = "colorized"
+
 [tool.pylint.TYPECHECK]
 # pylint is unable to detect Namespace attributes and will throw a E1101
 generated-members = "options.*"
@@ -233,7 +236,7 @@ python_files = [
 xfail_strict = true
 
 [tool.ruff]
-required-version = "0.0.291"
+required-version = "0.0.292"
 ignore = [
   "D203", # incompatible with D211
   "D213", # incompatible with D212

src/ansiblelint/__main__.py

@@ -271,7 +271,7 @@ def fix(runtime_options: Options, result: LintResult, rules: RulesCollection) ->
         result.matches.pop(idx)
 
 
-# pylint: disable=too-many-statements,too-many-locals
+# pylint: disable=too-many-locals
 def main(argv: list[str] | None = None) -> int:
     """Linter CLI entry point."""
     # alter PATH if needed (venv support)

src/ansiblelint/config.py

@@ -104,7 +104,7 @@
 
 
 @dataclass
-class Options:  # pylint: disable=too-many-instance-attributes,too-few-public-methods
+class Options:  # pylint: disable=too-many-instance-attributes
     """Store ansible-lint effective configuration options."""
 
     # Private attributes
@@ -247,7 +247,6 @@ def guess_install_method() -> str:
             else:
                 logging.debug("Skipping %s as it is not installed.", package_name)
                 use_pip = False
-    # pylint: disable=broad-except
     except (AttributeError, ModuleNotFoundError) as exc:
         # On Fedora 36, we got a AttributeError exception from pip that we want to avoid
         # On NixOS, we got a ModuleNotFoundError exception from pip that we want to avoid

src/ansiblelint/file_utils.py

@@ -254,7 +254,7 @@ def __init__(
             self.parent = _guess_parent(self)
 
         if self.kind == "yaml":
-            _ = self.data  # pylint: disable=pointless-statement
+            _ = self.data
 
         if self.kind == "plugin":
             # pylint: disable=consider-using-with

src/ansiblelint/rules/__init__.py

@@ -328,7 +328,6 @@ def transform(self, match, lintable, data):
         return target
 
 
-# pylint: disable=too-many-nested-blocks
 def load_plugins(
     dirs: list[str],
 ) -> Iterator[AnsibleLintRule]:

src/ansiblelint/rules/args.py

@@ -103,7 +103,7 @@ def matchtask(
         task: Task,
         file: Lintable | None = None,
     ) -> list[MatchError]:
-        # pylint: disable=too-many-locals,too-many-return-statements
+        # pylint: disable=too-many-return-statements
         results: list[MatchError] = []
         module_name = task["action"]["__ansible_module_original__"]
         failed_msg = None

src/ansiblelint/rules/avoid_implicit.py

@@ -40,8 +40,8 @@ def matchtask(
 
 # testing code to be loaded only with pytest or when executed the rule file
 if "pytest" in sys.modules:
-    from ansiblelint.rules import RulesCollection  # pylint: disable=ungrouped-imports
-    from ansiblelint.runner import Runner  # pylint: disable=ungrouped-imports
+    from ansiblelint.rules import RulesCollection
+    from ansiblelint.runner import Runner
 
     def test_template_instead_of_copy_positive() -> None:
         """Positive test for avoid-implicit."""

src/ansiblelint/rules/command_instead_of_module.py

@@ -108,8 +108,9 @@ def matchtask(
 if "pytest" in sys.modules:
     import pytest
 
-    from ansiblelint.rules import RulesCollection  # pylint: disable=ungrouped-imports
-    from ansiblelint.runner import Runner  # pylint: disable=ungrouped-imports
+    # pylint: disable=ungrouped-imports
+    from ansiblelint.rules import RulesCollection
+    from ansiblelint.runner import Runner
 
     @pytest.mark.parametrize(
         ("file", "expected"),

src/ansiblelint/rules/command_instead_of_shell.py

@@ -83,8 +83,9 @@ def transform(
 if "pytest" in sys.modules:
     import pytest
 
-    from ansiblelint.rules import RulesCollection  # pylint: disable=ungrouped-imports
-    from ansiblelint.runner import Runner  # pylint: disable=ungrouped-imports
+    # pylint: disable=ungrouped-imports
+    from ansiblelint.rules import RulesCollection
+    from ansiblelint.runner import Runner
 
     @pytest.mark.parametrize(
         ("file", "expected"),

src/ansiblelint/rules/complexity.py

@@ -76,8 +76,9 @@ def calculate_block_depth(self, task: Task) -> int:
 if "pytest" in sys.modules:
     import pytest
 
-    from ansiblelint.config import options  # pylint: disable=ungrouped-imports
-    from ansiblelint.runner import Runner  # pylint: disable=ungrouped-imports
+    # pylint: disable=ungrouped-imports
+    from ansiblelint.config import options
+    from ansiblelint.runner import Runner
 
     @pytest.mark.parametrize(
         ("file", "expected_results"),

src/ansiblelint/rules/deprecated_local_action.py

@@ -84,8 +84,8 @@ def transform(
 
 # testing code to be loaded only with pytest or when executed the rule file
 if "pytest" in sys.modules:
-    from ansiblelint.rules import RulesCollection  # pylint: disable=ungrouped-imports
-    from ansiblelint.runner import Runner  # pylint: disable=ungrouped-imports
+    from ansiblelint.rules import RulesCollection
+    from ansiblelint.runner import Runner
 
     def test_local_action(default_rules_collection: RulesCollection) -> None:
         """Positive test deprecated_local_action."""

src/ansiblelint/rules/empty_string_compare.py

@@ -54,8 +54,8 @@ def matchtask(
 
 # testing code to be loaded only with pytest or when executed the rule file
 if "pytest" in sys.modules:
-    from ansiblelint.rules import RulesCollection  # pylint: disable=ungrouped-imports
-    from ansiblelint.runner import Runner  # pylint: disable=ungrouped-imports
+    from ansiblelint.rules import RulesCollection
+    from ansiblelint.runner import Runner
 
     def test_rule_empty_string_compare_fail() -> None:
         """Test rule matches."""

src/ansiblelint/rules/fqcn.py

@@ -241,7 +241,7 @@ def transform(
 # testing code to be loaded only with pytest or when executed the rule file
 if "pytest" in sys.modules:
     from ansiblelint.rules import RulesCollection
-    from ansiblelint.runner import Runner  # pylint: disable=ungrouped-imports
+    from ansiblelint.runner import Runner
 
     def test_fqcn_builtin_fail() -> None:
         """Test rule matches."""

src/ansiblelint/rules/galaxy.py

@@ -122,7 +122,6 @@ def matchplay(self, file: Lintable, data: dict[str, Any]) -> list[MatchError]:
             results.append(
                 self.create_matcherror(
                     message="collection version should be greater than or equal to 1.0.0",
-                    # pylint: disable=protected-access
                     lineno=version._line_number,  # noqa: SLF001
                     tag="galaxy[version-incorrect]",
                     filename=file,

src/ansiblelint/rules/ignore_errors.py

@@ -44,7 +44,7 @@ def matchtask(
     import pytest
 
     if TYPE_CHECKING:
-        from ansiblelint.testing import RunFromText  # pylint: disable=ungrouped-imports
+        from ansiblelint.testing import RunFromText
 
     IGNORE_ERRORS_TRUE = """
 - hosts: all

src/ansiblelint/rules/jinja.py

@@ -219,7 +219,6 @@ def matchyaml(self, file: Lintable) -> list[MatchError]:
 
         if str(file.kind) == "vars":
             data = parse_yaml_from_file(str(file.path))
-            # pylint: disable=unused-variable
             for key, v, _path in nested_items_path(data):
                 if isinstance(v, AnsibleUnicode):
                     reformatted, details, tag = self.check_whitespace(
@@ -287,7 +286,7 @@ def unlex(self, tokens: list[Token]) -> str:
             last_value = value
         return result
 
-    # pylint: disable=too-many-statements,too-many-locals
+    # pylint: disable=too-many-locals
     def check_whitespace(
         self,
         text: str,
@@ -386,8 +385,6 @@ def uncook(value: str, *, implicit: bool = False) -> str:
 
         except jinja2.exceptions.TemplateSyntaxError as exc:
             return "", str(exc.message), "invalid"
-        # https://github.com/PyCQA/pylint/issues/7433 - py311 only
-        # pylint: disable=c-extension-no-member
         except (NotImplementedError, black.parsing.InvalidInput) as exc:
             # black is not able to recognize all valid jinja2 templates, so we
             # just ignore InvalidInput errors.
@@ -482,11 +479,10 @@ def blacken(text: str) -> str:
 if "pytest" in sys.modules:
     import pytest
 
-    from ansiblelint.rules import RulesCollection  # pylint: disable=ungrouped-imports
-    from ansiblelint.runner import Runner
-
     # pylint: disable=ungrouped-imports
-    from ansiblelint.transformer import Transformer  # pylint: disable=ungrouped-imports
+    from ansiblelint.rules import RulesCollection
+    from ansiblelint.runner import Runner
+    from ansiblelint.transformer import Transformer
 
     @pytest.fixture(name="error_expected_lines")
     def fixture_error_expected_lines() -> list[int]:

src/ansiblelint/rules/key_order.py

@@ -116,8 +116,9 @@ def transform(
 if "pytest" in sys.modules:
     import pytest
 
-    from ansiblelint.rules import RulesCollection  # pylint: disable=ungrouped-imports
-    from ansiblelint.runner import Runner  # pylint: disable=ungrouped-imports
+    # pylint: disable=ungrouped-imports
+    from ansiblelint.rules import RulesCollection
+    from ansiblelint.runner import Runner
 
     @pytest.mark.parametrize(
         ("test_file", "failures"),

src/ansiblelint/rules/literal_compare.py

@@ -55,8 +55,9 @@ def matchtask(
 if "pytest" in sys.modules:
     import pytest
 
-    from ansiblelint.rules import RulesCollection  # pylint: disable=ungrouped-imports
-    from ansiblelint.runner import Runner  # pylint: disable=ungrouped-imports
+    # pylint: disable=ungrouped-imports
+    from ansiblelint.rules import RulesCollection
+    from ansiblelint.runner import Runner
 
     @pytest.mark.parametrize(
         ("test_file", "failures"),

src/ansiblelint/rules/loop_var_prefix.py

@@ -81,8 +81,9 @@ def matchtask(
 if "pytest" in sys.modules:
     import pytest
 
-    from ansiblelint.rules import RulesCollection  # pylint: disable=ungrouped-imports
-    from ansiblelint.runner import Runner  # pylint: disable=ungrouped-imports
+    # pylint: disable=ungrouped-imports
+    from ansiblelint.rules import RulesCollection
+    from ansiblelint.runner import Runner
 
     @pytest.mark.parametrize(
         ("test_file", "failures"),

src/ansiblelint/rules/meta_incorrect.py

@@ -56,8 +56,8 @@ def matchyaml(self, file: Lintable) -> list[MatchError]:
 
 
 if "pytest" in sys.modules:
-    from ansiblelint.rules import RulesCollection  # pylint: disable=ungrouped-imports
-    from ansiblelint.runner import Runner  # pylint: disable=ungrouped-imports
+    from ansiblelint.rules import RulesCollection
+    from ansiblelint.runner import Runner
 
     def test_default_galaxy_info(
         default_rules_collection: RulesCollection,

src/ansiblelint/rules/meta_runtime.py

@@ -80,8 +80,9 @@ def matchyaml(self, file: Lintable) -> list[MatchError]:
 if "pytest" in sys.modules:
     import pytest
 
-    from ansiblelint.rules import RulesCollection  # pylint: disable=ungrouped-imports
-    from ansiblelint.runner import Runner  # pylint: disable=ungrouped-imports
+    # pylint: disable=ungrouped-imports
+    from ansiblelint.rules import RulesCollection
+    from ansiblelint.runner import Runner
 
     @pytest.mark.parametrize(
         ("test_file", "failures", "tags"),

src/ansiblelint/rules/meta_video_links.py

@@ -86,8 +86,9 @@ def matchyaml(self, file: Lintable) -> list[MatchError]:
 if "pytest" in sys.modules:
     import pytest
 
-    from ansiblelint.rules import RulesCollection  # pylint: disable=ungrouped-imports
-    from ansiblelint.runner import Runner  # pylint: disable=ungrouped-imports
+    # pylint: disable=ungrouped-imports
+    from ansiblelint.rules import RulesCollection
+    from ansiblelint.runner import Runner
 
     @pytest.mark.parametrize(
         ("test_file", "failures"),

src/ansiblelint/rules/name.py

@@ -255,6 +255,5 @@ def test_name_template() -> None:
     def test_when_no_lintable() -> None:
         """Test when lintable is None."""
         name_rule = NameRule()
-        # pylint: disable=protected-access
         result = name_rule._prefix_check("Foo", None, 1)  # noqa: SLF001
         assert len(result) == 0

src/ansiblelint/rules/no_changed_when.py

@@ -75,8 +75,9 @@ def matchtask(
 if "pytest" in sys.modules:
     import pytest
 
-    from ansiblelint.rules import RulesCollection  # pylint: disable=ungrouped-imports
-    from ansiblelint.runner import Runner  # pylint: disable=ungrouped-imports
+    # pylint: disable=ungrouped-imports
+    from ansiblelint.rules import RulesCollection
+    from ansiblelint.runner import Runner
 
     @pytest.mark.parametrize(
         ("file", "expected"),

src/ansiblelint/rules/no_free_form.py

@@ -164,8 +164,9 @@ def filter_values(
 if "pytest" in sys.modules:
     import pytest
 
-    from ansiblelint.rules import RulesCollection  # pylint: disable=ungrouped-imports
-    from ansiblelint.runner import Runner  # pylint: disable=ungrouped-imports
+    # pylint: disable=ungrouped-imports
+    from ansiblelint.rules import RulesCollection
+    from ansiblelint.runner import Runner
 
     @pytest.mark.parametrize(
         ("file", "expected"),

src/ansiblelint/rules/no_handler.py

@@ -86,8 +86,9 @@ def matchtask(
 if "pytest" in sys.modules:
     import pytest
 
-    from ansiblelint.rules import RulesCollection  # pylint: disable=ungrouped-imports
-    from ansiblelint.runner import Runner  # pylint: disable=ungrouped-imports
+    # pylint: disable=ungrouped-imports
+    from ansiblelint.rules import RulesCollection
+    from ansiblelint.runner import Runner
 
     @pytest.mark.parametrize(
         ("test_file", "failures"),

src/ansiblelint/rules/no_log_password.py

@@ -97,7 +97,7 @@ def transform(
     import pytest
 
     if TYPE_CHECKING:
-        from ansiblelint.testing import RunFromText  # pylint: disable=ungrouped-imports
+        from ansiblelint.testing import RunFromText
 
     NO_LOG_UNUSED = """
 - name: Test

src/ansiblelint/rules/no_prompting.py

@@ -61,8 +61,8 @@ def matchtask(
 
 if "pytest" in sys.modules:
     from ansiblelint.config import options
-    from ansiblelint.rules import RulesCollection  # pylint: disable=ungrouped-imports
-    from ansiblelint.runner import Runner  # pylint: disable=ungrouped-imports
+    from ansiblelint.rules import RulesCollection
+    from ansiblelint.runner import Runner
 
     def test_no_prompting_fail() -> None:
         """Negative test for no-prompting."""

src/ansiblelint/rules/no_relative_paths.py

@@ -53,8 +53,9 @@ def matchtask(
 if "pytest" in sys.modules:
     import pytest
 
-    from ansiblelint.rules import RulesCollection  # pylint: disable=ungrouped-imports
-    from ansiblelint.runner import Runner  # pylint: disable=ungrouped-imports
+    # pylint: disable=ungrouped-imports
+    from ansiblelint.rules import RulesCollection
+    from ansiblelint.runner import Runner
 
     @pytest.mark.parametrize(
         ("test_file", "failures"),

src/ansiblelint/rules/no_same_owner.py

@@ -84,8 +84,9 @@ def handle_unarchive(task: Any, action: dict[str, Any]) -> bool:
 if "pytest" in sys.modules:
     import pytest
 
-    from ansiblelint.rules import RulesCollection  # pylint: disable=ungrouped-imports
-    from ansiblelint.runner import Runner  # pylint: disable=ungrouped-imports
+    # pylint: disable=ungrouped-imports
+    from ansiblelint.rules import RulesCollection
+    from ansiblelint.runner import Runner
 
     @pytest.mark.parametrize(
         ("test_file", "failures"),