Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add templates list as option #19

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

jwoogee
Copy link

@jwoogee jwoogee commented Dec 19, 2018

Adding config_manager_templates as an option for this role so we can pass a list of names of templates to apply, there is a template, config_sections.j2 that combines the templates so we can easily apply whichever templates we want with this role. I'm updating cisco_ios to accommodate this also.

@privateip
Copy link
Contributor

Responding here as well based on discussion in ansiblenetwork slack channel. The config_manager role already supports passing in a J2 template with the resulting output being passed to the provider role so I believe this PR is a little redundant.

@jwoogee
Copy link
Author

jwoogee commented Jan 17, 2019

The difference is that config_manager_templates expects a list of templates to load into config_sections.j2 when it gets to ansible-network.cisco_ios(other vendor specific roles would get the same benefit with the addition). This makes it functional to get all facts in one role, then load all necessary templates in one run of the config_manager role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants