Merge pull request #13 from guidograzioli/1_1_1_linter

ah linter changes

roles/jbcs/defaults/main.yml

@@ -5,7 +5,7 @@ jbcs_ssl_port: 443
 jbcs_version: '2.4.57'
 jbcs_distro: RHEL8
 jbcs_arch: x86_64
-jbcs_bundle_prefix:  "jbcs-httpd24-httpd"
+jbcs_bundle_prefix: "jbcs-httpd24-httpd"
 
 jbcs_bundle: "{{ jbcs_bundle_prefix }}-{{ jbcs_version }}-{{ jbcs_distro }}-{{ jbcs_arch }}.zip"
 jbcs_patch_bundle: "{{ jbcs_bundle_prefix }}-{{ jbcs_version }}-SP[1-9][0-9]*-{{ jbcs_distro }}-{{ jbcs_arch }}.zip"

roles/jbcs/tasks/install.yml

@@ -41,7 +41,7 @@
     path: "{{ jbcs_zip_path }}"
     owner: "{{ httpd.user.name }}"
     group: "{{ httpd.group.name }}"
-    mode: 0750
+    mode: '0750'
     state: directory
 
 ## check remote archive
@@ -94,7 +94,7 @@
     - name: Determine install zipfile from search results
       ansible.builtin.set_fact:
         rhn_filtered_products: "{{ rhn_products.results | selectattr('file_path', 'match', \
-                                     '.*/' + [ jbcs_bundle_prefix, jbcs_version, jbcs_distro, jbcs_arch ] | join('-') + '.zip') }}"
+                                   '.*/' + [ jbcs_bundle_prefix, jbcs_version, jbcs_distro, jbcs_arch ] | join('-') + '.zip') }}"
       delegate_to: localhost
       run_once: true
 
@@ -121,7 +121,7 @@
     dest: "{{ archive }}"
     owner: "{{ httpd.user.name }}"
     group: "{{ httpd.group.name }}"
-    mode: 0640
+    mode: '0640'
   register: new_version_downloaded
   when:
     - not archive_path.stat.exists

roles/jbcs/tasks/main.yml

@@ -26,7 +26,7 @@
     dest: "{{ httpd.home }}/httpd/conf.d/mod_cluster.conf"
     owner: "{{ httpd.user.name }}"
     group: "{{ httpd.group.name }}"
-    mode: 0640
+    mode: '0640'
   when: jbcs_mod_cluster_enable
   notify:
     - 'Expire mod_cluster cache and restart'

roles/jbcs/tasks/patch.yml

@@ -21,7 +21,7 @@
       ansible.builtin.set_fact:
         rhn_filtered_products: "{{ rhn_products.results | map(attribute='file_path') | \
                                    select('match', '^[^/]*/' + jbcs_patch_bundle + '$') | \
-                                   map('regex_replace', '[^/]*/' + jbcs_bundle_prefix + '-' + jbcs_version + '-SP([1-9][0-9]*)-.*', '\\1' ) | \
+                                   map('regex_replace', '[^/]*/' + jbcs_bundle_prefix + '-' + jbcs_version + '-SP([1-9][0-9]*)-.*', '\\1') | \
                                    list | unique }}"
       delegate_to: localhost
       run_once: true
@@ -35,7 +35,7 @@
     - name: Determine latest patch version
       ansible.builtin.set_fact:
         rhn_filtered_products: "{{ rhn_products.results | selectattr('file_path', 'match', \
-                                     '[^/]*/' + [ jbcs_bundle_prefix, jbcs_version, latest_patch_version, jbcs_distro, jbcs_arch ] | join('-') + '.zip$') }}"
+                                   '[^/]*/' + [ jbcs_bundle_prefix, jbcs_version, latest_patch_version, jbcs_distro, jbcs_arch ] | join('-') + '.zip$') }}"
       delegate_to: localhost
       run_once: true
 
@@ -116,7 +116,7 @@
     dest: "{{ archive }}"
     owner: "{{ httpd.user.name }}"
     group: "{{ httpd.group.name }}"
-    mode: 0640
+    mode: '0640'
   register: new_version_downloaded
   when:
     - not archive_path.stat.exists

roles/jbcs/tasks/post_install.yml

@@ -6,7 +6,7 @@
     dest: "/usr/lib/systemd/system/{{ jbcs_service_name }}.service"
     owner: "{{ httpd.user.name }}"
     group: "{{ httpd.group.name }}"
-    mode: 0640
+    mode: '0640'
   notify:
     - "Reload systemd"
 
@@ -18,13 +18,13 @@
     - name: 00-base.conf
       dest: "{{ httpd.home }}/httpd/conf.modules.d"
     - name: httpd.conf
-      dest:  "{{ httpd.home }}/httpd/conf"
+      dest: "{{ httpd.home }}/httpd/conf"
   ansible.builtin.template:
     src: "templates/{{ item.name }}.j2"
     dest: "{{ item.dest }}/{{ item.name }}"
     owner: "{{ httpd.user.name }}"
     group: "{{ httpd.group.name }}"
-    mode: 0640
+    mode: '0640'
 
 - name: Ensure JBCS module configuration is correct
   become: true

roles/jbcs/tasks/ssl.yml

@@ -35,7 +35,7 @@
         state: hard
         owner: "{{ httpd.user.name }}"
         group: "{{ httpd.group.name }}"
-        mode: 0640
+        mode: '0640'
       when:
         - ssl_conf_file.stat.exists
         - not ssl_conf_disabled_file.stat.exists
@@ -55,7 +55,7 @@
         dest: "{{ ssl_conf }}"
         owner: "{{ httpd.user.name }}"
         group: "{{ httpd.group.name }}"
-        mode: 0640
+        mode: '0640'
       notify:
         - Restart JBCS