Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main updated and release #85

Merged
merged 54 commits into from
Aug 14, 2024
Merged

Main updated and release #85

merged 54 commits into from
Aug 14, 2024

Conversation

uk-bolly
Copy link
Member

@uk-bolly uk-bolly commented Aug 13, 2024

Overall Review of Changes:
Many open issues
pipeline updates
audit improvements
pre-commit updates
jmespath removal

Issue Fixes:
#21
#23
#25
#29
#31
#39
#43
#45
#47
#49
#51
#53
#55
#57
#58
#64
#66
#67
#68
#73
#75

Enhancements:
Audit improvements
new pipeline

How has this been tested?:
Manually and pipeline

DianaMariaDDM and others added 30 commits December 6, 2023 14:56
…r-baseline-automations/ansible-lockdown/amazon2023-cis/-/issues/2 by using `import_tasks` module so as the rules will get added and executed!

Signed-off-by: Diana-Maria Dumitru <[email protected]>
…r-baseline-automations/ansible-lockdown/amazon2023-cis/-/issues/5 by adding the necessary lines to both sshd_config file and sshd_config.d/ files. The same method is used for all the rules from 4.2.x, to make them compliant with CISs checks.

Signed-off-by: Diana-Maria Dumitru <[email protected]>
Signed-off-by: Diana-Maria Dumitru <[email protected]>
Signed-off-by: Diana-Maria Dumitru <[email protected]>
Signed-off-by: Diana-Maria Dumitru <[email protected]>
…that requires the root password to be set

Signed-off-by: Diana-Maria Dumitru <[email protected]>
…e it was not supposed to be there!

Signed-off-by: Diana-Maria Dumitru <[email protected]>
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v4.5.0](pre-commit/pre-commit-hooks@v4.4.0...v4.5.0)
- [github.com/gitleaks/gitleaks: v8.17.0 → v8.18.2](gitleaks/gitleaks@v8.17.0...v8.18.2)
- [github.com/ansible-community/ansible-lint: v6.18.0 → v24.2.0](ansible/ansible-lint@v6.18.0...v24.2.0)
- [github.com/adrienverge/yamllint.git: v1.32.0 → v1.35.1](https://github.com/adrienverge/yamllint.git/compare/v1.32.0...v1.35.1)
…s it was implementing something needed by 6.1.10.

Signed-off-by: Diana-Maria Dumitru <[email protected]>
Signed-off-by: Diana-Maria Dumitru <[email protected]>
uk-bolly and others added 23 commits February 22, 2024 12:41
…_r_5_3

Removing double import of "cis_5.3.yml".
…all_authconfig

Removing prelim for installing authconfig, as it is not used.
…allation is removed!

Signed-off-by: Diana-Maria Dumitru <[email protected]>
Removing `amzn2023cis_use_authconfig` variable.
* updated to use ansible_facts variables

Signed-off-by: Mark Bolwell <[email protected]>

* Squashed commit of the following:

commit 0cad737fe35db33ff0b867ac4439688cd2bcb009
Author: Mark Bolwell <[email protected]>
Date:   Fri Feb 23 09:41:39 2024 +0000

    updated and tidied up

    Signed-off-by: Mark Bolwell <[email protected]>

commit 1fa72013209866be66f7f2a353b9cf6264a3681d
Author: Mark Bolwell <[email protected]>
Date:   Fri Feb 23 09:41:10 2024 +0000

    audit_only

    Signed-off-by: Mark Bolwell <[email protected]>

Signed-off-by: Mark Bolwell <[email protected]>

* Always tag for 1.2.1 gpg_key package update #14

Signed-off-by: Mark Bolwell <[email protected]>

* tidy up prelim removal step

Signed-off-by: Mark Bolwell <[email protected]>

* updated changelog

Signed-off-by: Mark Bolwell <[email protected]>

* removed inject facts as vars

Signed-off-by: Mark Bolwell <[email protected]>

* 4.6.5 related to #27 thanks to @DianaMariaDDM

Signed-off-by: Mark Bolwell <[email protected]>

* 6.1.10 thanks to @DianaMariaDDM #37

Signed-off-by: Mark Bolwell <[email protected]>

* tage change to alwasy thanks to @DianaMariaDDM #41

Signed-off-by: Mark Bolwell <[email protected]>

* updated changelog

Signed-off-by: Mark Bolwell <[email protected]>

* updated changelog

Signed-off-by: Mark Bolwell <[email protected]>

---------

Signed-off-by: Mark Bolwell <[email protected]>
* updated ansible fact naming for ansible_facts.virtualization_type

Signed-off-by: Mark Bolwell <[email protected]>

* updated checkout version

Signed-off-by: Mark Bolwell <[email protected]>

* ansible fact update

Signed-off-by: Mark Bolwell <[email protected]>

* updated ansible facts and timeout now inherited

Signed-off-by: Mark Bolwell <[email protected]>

---------

Signed-off-by: Mark Bolwell <[email protected]>
updates:
- [github.com/ansible-community/ansible-lint: v24.2.0 → v24.2.1](ansible/ansible-lint@v24.2.0...v24.2.1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* addressed #59 thanks to @DianaMariaDDM

Signed-off-by: Mark Bolwell <[email protected]>

* issue #59 thanks to @DianaMariaDDM

Signed-off-by: Mark Bolwell <[email protected]>

* issue #62 thanks to @DianaMariaDDM

Signed-off-by: Mark Bolwell <[email protected]>

* updated variable name in conditional

Signed-off-by: Mark Bolwell <[email protected]>

* updated

Signed-off-by: Mark Bolwell <[email protected]>

* updated container check

Signed-off-by: Mark Bolwell <[email protected]>

* updated authselect PR

Signed-off-by: Mark Bolwell <[email protected]>

* fix conditional typo

Signed-off-by: Mark Bolwell <[email protected]>

* fix conditional typo

Signed-off-by: Mark Bolwell <[email protected]>

* fix var typo

Signed-off-by: Mark Bolwell <[email protected]>

---------

Signed-off-by: Mark Bolwell <[email protected]>
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
updates:
- [github.com/ansible-community/ansible-lint: v24.2.1 → v24.2.2](ansible/ansible-lint@v24.2.1...v24.2.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
updates:
- [github.com/Yelp/detect-secrets: v1.4.0 → v1.5.0](Yelp/detect-secrets@v1.4.0...v1.5.0)
- [github.com/gitleaks/gitleaks: v8.18.2 → v8.18.3](gitleaks/gitleaks@v8.18.2...v8.18.3)
- [github.com/ansible-community/ansible-lint: v24.2.2 → v24.5.0](ansible/ansible-lint@v24.2.2...v24.5.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Added tag to allow post remediation task to run when specified.

Signed-off-by: Dimitris Kambouris <[email protected]>

* Removed trailing white space

* Added end of file line

Signed-off-by: Dimitris Kambouris <[email protected]>

---------

Signed-off-by: Dimitris Kambouris <[email protected]>
updates:
- [github.com/ansible-community/ansible-lint: v24.5.0 → v24.6.0](ansible/ansible-lint@v24.5.0...v24.6.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
updates:
- [github.com/gitleaks/gitleaks: v8.18.3 → v8.18.4](gitleaks/gitleaks@v8.18.3...v8.18.4)
- [github.com/ansible-community/ansible-lint: v24.6.0 → v24.7.0](ansible/ansible-lint@v24.6.0...v24.7.0)
* added missing tag

Signed-off-by: Mark Bolwell <[email protected]>

* removed comment as only one package

Signed-off-by: Mark Bolwell <[email protected]>

* fix typo

Signed-off-by: Mark Bolwell <[email protected]>

* updated gpg key

Signed-off-by: Mark Bolwell <[email protected]>

* Updated python_packages

Signed-off-by: Mark Bolwell <[email protected]>

* addressed #82 thansk to @darrias

Signed-off-by: Mark Bolwell <[email protected]>

* Updated workflow

Signed-off-by: Mark Bolwell <[email protected]>

* removed jmespath dependancy

Signed-off-by: Mark Bolwell <[email protected]>

* updated audit

Signed-off-by: Mark Bolwell <[email protected]>

* removed files and updated

Signed-off-by: Mark Bolwell <[email protected]>

* updated

Signed-off-by: Mark Bolwell <[email protected]>

* removed jmespath req

Signed-off-by: Mark Bolwell <[email protected]>

---------

Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly uk-bolly requested a review from georgenalen August 13, 2024 07:39
Copy link

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@uk-bolly
Copy link
Member Author

@uk-bolly uk-bolly merged commit c42b619 into main Aug 14, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants