Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HTML #44

Merged
merged 5 commits into from
Jan 26, 2022
Merged

Fix HTML #44

merged 5 commits into from
Jan 26, 2022

Conversation

felixfontein
Copy link
Collaborator

The theme currently generates invalid HTML, see ansible-community/antsibull-docs#66. This PR fixes the HTML.

@felixfontein felixfontein mentioned this pull request Jan 14, 2022
Merged
This was referenced Jan 14, 2022
Merged
Open
webknjaz
webknjaz reviewed Jan 14, 2022
View reviewed changes
tox.ini Outdated Show resolved Hide resolved
@felixfontein felixfontein mentioned this pull request Jan 14, 2022
Merged
briantist
briantist approved these changes Jan 19, 2022
View reviewed changes
Copy link

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. How did we catch this? Did someone run it through a validator or something?

@felixfontein
Copy link
Collaborator Author

@briantist yes, see https://www.reddit.com/r/ansible/comments/s1kb8e/ansible_moduleplugins_docs_now_use_simplified/ (resp. ansible-community/antsibull-docs#66). Also lynx complains on the invalid HTML (run lynx https://sphinx-ansible-theme.readthedocs.io/en/latest/, then you can see that it says ** Bad HTML!! Use -trace to diagnose. **).

@felixfontein
Copy link
Collaborator Author

@webknjaz is there any chance of this getting merged and released soon? The theme currently generates invalid HTML.

@webknjaz webknjaz merged commit 31d3b3f into ansible-community:master Jan 26, 2022
@webknjaz
Copy link
Member

@webknjaz is there any chance of this getting merged and released soon? The theme currently generates invalid HTML.

Done: https://github.com/ansible-community/sphinx_ansible_theme/runs/4951560463?check_suite_focus=true#step:10:29

@felixfontein felixfontein deleted the fix-html branch January 26, 2022 18:35
@felixfontein
Copy link
Collaborator Author

@webknjaz @briantist thanks for reviewing and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briantist briantist briantist approved these changes

@webknjaz webknjaz webknjaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @webknjaz @briantist