Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix some issues pointed out by zizmor #3

Merged
merged 1 commit into from
Dec 14, 2024
Merged

CI: Fix some issues pointed out by zizmor #3

merged 1 commit into from
Dec 14, 2024

Conversation

felixfontein
Copy link
Contributor

Fix some issues in GHA workflows pointed out by zizmor (https://github.com/woodruffw/zizmor).

Some more issues are pointed out:

error[excessive-permissions]: overly broad workflow or job-level permissions
  --> /home/felix/projects/code/github-cloned/antsibull-nightly-builds/.github/workflows/build-dumb-pypi.yml:38:1
   |
38 | / permissions:
39 | |   contents: read
40 | |   pages: write
41 | |   id-token: write
   | |_________________^ pages: write is overly broad at the workflow level
   |
   = note: audit confidence → High

error[excessive-permissions]: overly broad workflow or job-level permissions
  --> /home/felix/projects/code/github-cloned/antsibull-nightly-builds/.github/workflows/build-dumb-pypi.yml:38:1
   |
38 | / permissions:
39 | |   contents: read
40 | |   pages: write
41 | |   id-token: write
   | |_________________^ id-token: write is overly broad at the workflow level
   |
   = note: audit confidence → High

If someone else wants to work on them, feel free!

@felixfontein felixfontein merged commit 3120bdf into main Dec 14, 2024
1 check passed
@felixfontein felixfontein deleted the ci branch December 14, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant