Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed AWX labels #28

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Fixed AWX labels #28

merged 1 commit into from
Nov 21, 2024

Conversation

miles-w-3
Copy link
Collaborator

Fixes oversight in #21 - corrects annotation key and makes templates able to handle multi-value map. Tested with the following values:

AWX:
  enabled: true
  annotations:
    foo: bar
    second: line
  labels:
    foo: baz
    second: line

Output:

# Source: awx-operator/templates/awx-deploy.yaml
apiVersion: awx.ansible.com/v1beta1
kind: AWX
metadata:
  name: awx
  namespace: default
  labels:
    foo: baz
    second: line
  annotations:
    foo: bar
    second: line
spec:
  admin_user: admin
  security_context_settings:
    runAsGroup: 0
    runAsUser: 0
    fsGroup: 0
    fsGroupChangePolicy: OnRootMismatch

@miles-w-3
Fixed AWX labels
9635579 
Signed-off-by: Miles Wilson <[email protected]>
@miles-w-3 miles-w-3 mentioned this pull request Nov 21, 2024
Merged
oraNod
oraNod approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick fix @miles-w-3

@oraNod oraNod merged commit ad74930 into ansible-community:main Nov 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oraNod oraNod oraNod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miles-w-3 @oraNod