Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zuul: Update versions of ansible and ansible-core tested #553

Merged
merged 2 commits into from
Jun 30, 2024

Conversation

dmsimard
Copy link
Contributor

We're up to Ansible 10 and ansible-core 2.17.

Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/20fd9a7d207c42318376e75819c685b0

✔️ ara-tox-py3 SUCCESS in 2m 43s
✔️ ara-tox-linters SUCCESS in 3m 49s
ara-basic-ansible-core-devel FAILURE in 5m 25s (non-voting)
ara-basic-ansible-10 FAILURE in 5m 27s
✔️ ara-basic-ansible-core-2.16 SUCCESS in 5m 45s
ara-basic-ansible-core-2.17 FAILURE in 5m 20s
✔️ ara-container-images SUCCESS in 12m 10s

@dmsimard
Copy link
Contributor Author

There is a change of behavior in ansible-core 2.17 where previously-expected vars files were saved and now they aren't:

2.16.7

Screenshot from 2024-06-14 21-28-01

2.17.0

Screenshot from 2024-06-14 21-27-56

@dmsimard
Copy link
Contributor Author

Now, it's not like ara relies on a stable ansible-core API to retrieve those files:

# Record all the files involved in the play
for path in play._loader._FILE_CACHE.keys():
# The cache can be pre-populated with files that aren't relevant to the playbook report
# If there are matches that should be ignored here, don't record them at all
ignored = False
for ignored_file_pattern in self.ignored_files:
if ignored_file_pattern in path:
self.log.debug(f"Ignoring file {path}, matched pattern: {ignored_file_pattern}")
ignored = True
break
if not ignored:
self._submit_thread("global", self._get_or_create_file, path)

There might be a better way to do this now, I will need to investigate.

We're up to Ansible 10 and ansible-core 2.17.
@dmsimard
Copy link
Contributor Author

I spent some time trying to understand the change in behavior and created an issue about it: #560

I'm not sure what to do with it for now but it's not an issue specific to the upcoming release of ara 1.7.0.
Any version of ara running with ansible-core 2.17 may notice a change in the number of saved files but the playbook and task files should still remain recorded for sure.

@dmsimard dmsimard force-pushed the update-ansible-versions branch from 0de251a to a3dae94 Compare June 30, 2024 20:50
@dmsimard dmsimard force-pushed the update-ansible-versions branch from a3dae94 to e3116aa Compare June 30, 2024 20:50
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/692272c530af46499c6c54c4d4663244

✔️ ara-tox-py3 SUCCESS in 2m 51s
✔️ ara-tox-linters SUCCESS in 2m 24s
✔️ ara-basic-ansible-core-devel SUCCESS in 6m 14s (non-voting)
✔️ ara-basic-ansible-10 SUCCESS in 5m 18s
✔️ ara-basic-ansible-core-2.16 SUCCESS in 5m 13s
✔️ ara-basic-ansible-core-2.17 SUCCESS in 6m 42s
✔️ ara-container-images SUCCESS in 11m 38s

@dmsimard dmsimard merged commit e7ee252 into ansible-community:master Jun 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant