add compatibility for pydantic v2 #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotmax23
force-pushed
the
pydanticv2-compat
branch
4 times, most recently
from
4960878 to
87da1f6
Compare
gotmax23
force-pushed
the
pydanticv2-compat
branch
3 times, most recently
from
fadd86d to
cdd9ea3
Compare
This uses the `pydantic.v1` compat module (well really, it's just an in-tree copy of the latest pydantic v1 release) so we can also support pydantic v2. Major changes to root models make it infeasible to support pydantic v2 natively without dropping support for v1. The `_pydantic_compat` module simplifies imports of the `pydantic.v1` compat module with pydantic v2. The pydantic.v1 compat module is always used when type checking. We have to force one of them when type checking, as type checkers cannot understand `try-except` imports.
pyre does not understand our _pydantic_compat module and spews errors.
gotmax23
force-pushed
the
pydanticv2-compat
branch
from
cdd9ea3 to
cdc8f7f
Compare
gotmax23
changed the title
|
Ready for review |
felixfontein
approved these changes
Dec 23, 2023
|
@gotmax23 thanks for this one as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the
pydantic.v1compat module (well really, it's just anin-tree copy of the latest pydantic v1 release) so we can also support
pydantic v2. Major changes to root models make it infeasible to support
pydantic v2 natively without dropping support for v1.
The
_pydantic_compatmodule simplifies imports of thepydantic.v1compat module with pydantic v2. The pydantic.v1 compat module is always
used when type checking. We have to force one of them when type
checking, as type checkers cannot understand
try-exceptimports.See ansible-community/antsibull-core#125.