[WIP]Suppress error when hosts key not found in playbook #178
Conversation
|
Build succeeded.
|
| try: | ||
| host = doc["hosts"] | ||
| host_present = True | ||
| except: | ||
| continue | ||
| finally: | ||
| if host_present: | ||
| logger.debug("play[%s], host = %s", idx, host) | ||
| doc["hosts"] = self.builder.ansible_host | ||
| break |
There was a problem hiding this comment.
@TomasTomecek These changes would suppress the error in #109. Another part of this issue to be solved is regarding the import playbook. Usually, one case to consider would be a single playbook imported which I guess I would repeat the process as done on the original playbook to modify the hosts key. But when we have multiple playbooks imported, choosing them with extra-args would complex this problem, I wish to know your thoughts regarding your design strategy which we can follow.
There was a problem hiding this comment.
the playbooks are being imported from within a playbook: it means that users can import from 0 to infinity playbooks and bender needs to be able to cope with that; I'd say that extra-args don't play a role here
I'm personally completely unsure why the error happened in the first place - I'd suggest creating a test case using the playbook specified in the issue and check closely what exactly is going wrong
There was a problem hiding this comment.
@TomasTomecek As I went through the issue's playbooks, I understood that ab is trying to extract the host key from the primary playbook (which is not present) so throws a keyError, Perhaps as we have the options of defining host in the imported playbooks, now ansible has to go step deeper to dig the host key from the imported playbooks, Am I on the right track?
regarding my changes, I have used the boolean flag host_present just to make sure that the host key is not present in the primary playbook then workout in the imported playbooks.
There was a problem hiding this comment.
extract the host key from the primary playbook (which is not present) so throws a keyError
I'm not sure if that's really happening or I may not understand what you're trying to say.
I still suggest to write a test case for the issue and diagnose the problem like that. I used import_playbook for CI purposes in my other PR so you can get inspired: https://github.com/ansible-community/ansible-bender/pull/179/files#diff-283706639170035ea2a7403ae0e60f2dR7
kmehant
changed the title
| host = doc["hosts"] | ||
| host_present = True | ||
| except: | ||
| continue |
There was a problem hiding this comment.
looking at my code, I can see that the host is retrieved only for logging purposes, so I'd instead do something like:
try:
host = doc["hosts"]
except KeyError:
host = "not set"and continue with the former flow
| try: | ||
| host = doc["hosts"] | ||
| host_present = True | ||
| except: | ||
| continue | ||
| finally: | ||
| if host_present: | ||
| logger.debug("play[%s], host = %s", idx, host) | ||
| doc["hosts"] = self.builder.ansible_host | ||
| break |
There was a problem hiding this comment.
the playbooks are being imported from within a playbook: it means that users can import from 0 to infinity playbooks and bender needs to be able to cope with that; I'd say that extra-args don't play a role here
I'm personally completely unsure why the error happened in the first place - I'd suggest creating a test case using the playbook specified in the issue and check closely what exactly is going wrong
Context