Update Debian.yml for Ubuntu arm64 compatibility #1219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use ansible_os_family to determine Ubuntu and Debian flavour.
remove redundant condition. Debian.yml is included using {{ansible_os_family}}.yml
pyrodie18
requested changes
May 7, 2024
eb4x
reviewed
May 8, 2024
| @@ -29,7 +29,7 @@ | |||
|
|
|||
| - name: "Debian | Repo URL" | |||
| ansible.builtin.set_fact: | |||
| zabbix_repo_deb_url: "{{ _zabbix_repo_deb_url }}/{{ ansible_lsb.id.lower() }}{{ '-arm64' if ansible_machine == 'aarch64' and ansible_lsb.id == 'debian' else ''}}" | |||
| zabbix_repo_deb_url: "{{ _zabbix_repo_deb_url }}/{{ ansible_lsb.id.lower() }}{{ '-arm64' if ansible_machine == 'aarch64' else ''}}" | |||
There was a problem hiding this comment.
This breaks raspbian for aarch64, you'll have to alter it to ansible_lsb.id in ['Debian', 'Ubuntu']
This was referenced May 8, 2024
Merged
|
Taken care of in #1225 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ansible_os_family to determine Ubuntu and Debian flavour.
SUMMARY
On ubuntu system (20.04 at least)
ansible_isb.idvalue is ubuntu not debian. Therefore auto-detection for ubuntuarm64doesn't work. Considering that Debian.yml is included using{{ansible_os_familiy}}.ymlwe can assume that this additionalandcondition is already covered by that.ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
Today if installed on Ubuntu arm64 (20.04 for example) installation of zabbix-agent2 fails as Zabbix default repository does not contain arm64 packages anymore.