Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing portion where building app pools with the word value fails. #587

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

AnsibleJosh
Copy link
Contributor

SUMMARY

For the last two years we've had an issue with this module regard app pool creations failing that specifically contain the word "value" in it. We weren't able to create sites that contained this word.

#410

Root cause is that the string "Value" is matched against collection of property objects of the $attribute_value but from the context it can be deduced that "Value" should only be matched against collection of names of those properties. Match should not be partial either, hence the -eq operator.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

community.win_iis_webapppool

ADDITIONAL INFORMATION

Copy link
Collaborator

@jborean93 jborean93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bugfix, is it possible to add a changelog fragment to document this bugfix https://docs.ansible.com/ansible/latest/community/development_process.html#creating-changelog-fragments

@AnsibleJosh
Copy link
Contributor Author

Thanks for the bugfix, is it possible to add a changelog fragment to document this bugfix https://docs.ansible.com/ansible/latest/community/development_process.html#creating-changelog-fragments

I'm not sure how to do that. I will check documentation and try my best.

@jborean93
Copy link
Collaborator

Basically create a file in the changelogs/fragments directory with something like

bugfixes:
  - >-
    win_iis_webapppool - Brief description of what is fixed
    - https://github.com/ansible-collections/community.windows/issues/410

@jborean93 jborean93 merged commit 237af1a into ansible-collections:main Nov 13, 2024
48 checks passed
@jborean93
Copy link
Collaborator

Thanks for the bugfix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants