add support for systemd creds encrypt/decrypt #9383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Sjögren <[email protected]>
ansibullbot
added
integration
Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
felixfontein
added
check-before-release
Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
russoz
reviewed
Dec 26, 2024
tests/integration/targets/systemd_creds_decrypt/tasks/main.yaml
Outdated
Show resolved
Hide resolved
tests/integration/targets/systemd_creds_decrypt/tasks/main.yaml
Outdated
Show resolved
Hide resolved
tests/integration/targets/systemd_creds_decrypt/tasks/main.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
Thanks for the help and guidance @felixfontein |
russoz
reviewed
Dec 29, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Co-authored-by: Alexei Znamensky <[email protected]>
Co-authored-by: Alexei Znamensky <[email protected]>
Co-authored-by: Alexei Znamensky <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
felixfontein
approved these changes
Dec 29, 2024
Backport to stable-10: 💚 backport PR created✅ Backport PR branch: Backported as #9468 🤖 @patchback |
felixfontein
removed
the
check-before-release
patchback bot
pushed a commit
that referenced
this pull request
Dec 29, 2024
* add support for systemd creds encrypt/decrypt Signed-off-by: Thomas Sjögren <[email protected]> * add __metaclass__ Signed-off-by: Thomas Sjögren <[email protected]> * Python 2.7 issues Signed-off-by: Thomas Sjögren <[email protected]> * update version_added and ci test aliases Signed-off-by: Thomas Sjögren <[email protected]> * switch to container Signed-off-by: Thomas Sjögren <[email protected]> * run tests in docker as well Signed-off-by: Thomas Sjögren <[email protected]> * move tasks into tasks/ Signed-off-by: Thomas Sjögren <[email protected]> * no need to call echo Signed-off-by: Thomas Sjögren <[email protected]> * lint and add become: Signed-off-by: Thomas Sjögren <[email protected]> * dont append a newline Signed-off-by: Thomas Sjögren <[email protected]> * don't clean newlines Signed-off-by: Thomas Sjögren <[email protected]> * only use module name Signed-off-by: Thomas Sjögren <[email protected]> * clean Signed-off-by: Thomas Sjögren <[email protected]> * change msg to value Signed-off-by: Thomas Sjögren <[email protected]> * add return values Signed-off-by: Thomas Sjögren <[email protected]> * update attributes and description Signed-off-by: Thomas Sjögren <[email protected]> * Update plugins/modules/systemd_creds_decrypt.py Co-authored-by: Felix Fontein <[email protected]> * set newline default Signed-off-by: Thomas Sjögren <[email protected]> * Update plugins/modules/systemd_creds_encrypt.py Co-authored-by: Alexei Znamensky <[email protected]> * Update plugins/modules/systemd_creds_encrypt.py Co-authored-by: Alexei Znamensky <[email protected]> * Update plugins/modules/systemd_creds_encrypt.py Co-authored-by: Alexei Znamensky <[email protected]> * update required and spelling Signed-off-by: Thomas Sjögren <[email protected]> * use single backslash Signed-off-by: Thomas Sjögren <[email protected]> --------- Signed-off-by: Thomas Sjögren <[email protected]> Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Alexei Znamensky <[email protected]> (cherry picked from commit 482a90e)
|
@konstruktoid thanks for your contribution! |
felixfontein
pushed a commit
that referenced
this pull request
Dec 29, 2024
… encrypt/decrypt (#9468) add support for systemd creds encrypt/decrypt (#9383) * add support for systemd creds encrypt/decrypt Signed-off-by: Thomas Sjögren <[email protected]> * add __metaclass__ Signed-off-by: Thomas Sjögren <[email protected]> * Python 2.7 issues Signed-off-by: Thomas Sjögren <[email protected]> * update version_added and ci test aliases Signed-off-by: Thomas Sjögren <[email protected]> * switch to container Signed-off-by: Thomas Sjögren <[email protected]> * run tests in docker as well Signed-off-by: Thomas Sjögren <[email protected]> * move tasks into tasks/ Signed-off-by: Thomas Sjögren <[email protected]> * no need to call echo Signed-off-by: Thomas Sjögren <[email protected]> * lint and add become: Signed-off-by: Thomas Sjögren <[email protected]> * dont append a newline Signed-off-by: Thomas Sjögren <[email protected]> * don't clean newlines Signed-off-by: Thomas Sjögren <[email protected]> * only use module name Signed-off-by: Thomas Sjögren <[email protected]> * clean Signed-off-by: Thomas Sjögren <[email protected]> * change msg to value Signed-off-by: Thomas Sjögren <[email protected]> * add return values Signed-off-by: Thomas Sjögren <[email protected]> * update attributes and description Signed-off-by: Thomas Sjögren <[email protected]> * Update plugins/modules/systemd_creds_decrypt.py Co-authored-by: Felix Fontein <[email protected]> * set newline default Signed-off-by: Thomas Sjögren <[email protected]> * Update plugins/modules/systemd_creds_encrypt.py Co-authored-by: Alexei Znamensky <[email protected]> * Update plugins/modules/systemd_creds_encrypt.py Co-authored-by: Alexei Znamensky <[email protected]> * Update plugins/modules/systemd_creds_encrypt.py Co-authored-by: Alexei Znamensky <[email protected]> * update required and spelling Signed-off-by: Thomas Sjögren <[email protected]> * use single backslash Signed-off-by: Thomas Sjögren <[email protected]> --------- Signed-off-by: Thomas Sjögren <[email protected]> Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Alexei Znamensky <[email protected]> (cherry picked from commit 482a90e) Co-authored-by: Thomas Sjögren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR adds systemd-creds encrypt/decrypt functionality.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
- Note that I haven't updated theversion_addedinformation.systemd-creds encryptencrypts the information using host specific settings, it needs to be run as well when testingsystemd-creds decrypt.systemd-creds encryptdoesn't support (unencrypted plaintext) input credential files as the systemd tool does, onlystdinas string.