Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default_without_diff callback #7949

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Add default_without_diff callback #7949

merged 2 commits into from
Feb 14, 2024

Conversation

felixfontein
Copy link
Collaborator

@felixfontein felixfontein commented Feb 6, 2024 •
edited
Loading

SUMMARY

Helps with ansible-community/ara#535.

ISSUE TYPE
  • New Module/Plugin Pull Request
COMPONENT NAME

default_without_diff

@felixfontein felixfontein added the backport-8 Automatically create a backport for the stable-8 branch label Feb 6, 2024
@felixfontein felixfontein mentioned this pull request Feb 6, 2024
Open
@ansibullbot ansibullbot added callback callback plugin has_issue integration tests/integration plugins plugin (any type) tests tests labels Feb 6, 2024
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Feb 6, 2024
@dmsimard
Copy link
Contributor

dmsimard commented Feb 6, 2024

LGTM 👍

@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Feb 6, 2024
dmsimard
dmsimard reviewed Feb 6, 2024
View reviewed changes
plugins/callback/default_without_diff.py
# Enable callback with environment variables:
environment_variable: |
ANSIBLE_STDOUT_CALLBACK=community.general.default_without_diff
'''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@rptaylor
Copy link

rptaylor commented Feb 6, 2024

Nice! Related to the original issue ansible/ansible#82445

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Feb 14, 2024
@felixfontein felixfontein merged commit 980fa36 into ansible-collections:main Feb 14, 2024
121 checks passed
@patchback Patchback
Copy link

patchback bot commented Feb 14, 2024 •
edited
Loading

Backport to stable-8: cherry-pick succeeded

Backport PR branch: patchback/backports/stable-8/980fa36facb2c103e2c16048aa209262dcf08950/pr-7949

PR branch created, proceeding with making a PR.

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the default-without-diff branch February 14, 2024 21:53
patchback bot pushed a commit that referenced this pull request Feb 14, 2024
@felixfontein @patchback
Add default_without_diff callback (#7949)
e1aa463 
* Add default_without_diff callback.

* Add examples and BOTMETA entry.

(cherry picked from commit 980fa36)
@felixfontein
Copy link
Collaborator Author

@dmsimard @rptaylor thanks for reviewing and commenting!

@felixfontein felixfontein mentioned this pull request Feb 14, 2024
Merged
felixfontein added a commit that referenced this pull request Feb 15, 2024
@felixfontein
[stable-8] Add default_without_diff callback (#7949) (#7968)
15a4650 
Add default_without_diff callback (#7949)

* Add default_without_diff callback.

* Add examples and BOTMETA entry.

(cherry picked from commit 980fa36)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmsimard dmsimard dmsimard approved these changes

Assignees
No one assigned
Labels
backport-8 Automatically create a backport for the stable-8 branch callback callback plugin has_issue integration tests/integration plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felixfontein @ansibullbot @dmsimard @rptaylor