Improve Ansible 2.9 compatibility #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
affects_2.10
bug
gundalow
approved these changes
May 8, 2020
|
@gundalow thanks for reviewing and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Parts of #296 which aren't experimental.
The first commit updates
ignore-2.9.txt, assuming that ansible/ansible#68345 has been backported (to avoid a huge list of wrong ignore entries).The second commit adds some compatibility code for
module.load_file_common_arguments()when used with the newpathkeyword argument, which is only available from Ansible 2.10 on (that feature was added in ansible/ansible#61659). This is similar to the change in ansible-collections/community.crypto#14: it restores the original 2.9 behavior of the module w.r.t. that call.ISSUE TYPE
COMPONENT NAME
tests/sanity/ignore-2.9.txt
archive
maven_artifact
java_keystore