Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version_added for all new features #214

Merged
merged 5 commits into from
Jun 13, 2020
Merged

Add version_added for all new features #214

merged 5 commits into from
Jun 13, 2020

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Adds version_added: '1.0.0' to all new features. I'll stick to 1.0.0 until we decided how we'll version and what's the next release.

CC @gundalow @abadger @Andersson007 @Akasurde

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
COMPONENT NAME

multiple

@ansibullbot
Copy link
Collaborator

cc @Alexander198961 @Dorn- @Jmainguy @Slezhuk @Xyon @Akasurde @alikins @amenonsen @andrew-d @andytom @b6d @bcoca @bmalynovytch @bmildren @danieljaouen @danowar2k @dinoocch @eryx12o45 @fishman @indrajitr @jasperla @jbscalia @jpdasma @kostiantyn-nemchenko @kurtdavis @kyleabenson @martinm82 @matburt @mator @mavit @michaelcoburn @nerzhul @Oneiroi @pertoft @scathatheworm @sebasmannem @tarka @tcraxs @the-maldridge @tolland @tomaszkiewicz @troy2914 @vincentvdk @xen0l @xiaozhu36
click here for bot help

@ansibullbot ansibullbot added WIP bug This issue/PR relates to a bug module module labels Apr 22, 2020
@ansibullbot
Copy link
Collaborator

cc @LinusU @MorrisA @d-little @flynn1973 @gforster @kairoaraujo @marvin-sinister @molekuul @ramooncamacho @wtcross
click here for bot help

@the-maldridge
Copy link

lgtm

@ansibullbot ansibullbot added the lookup lookup plugin label Apr 25, 2020
@felixfontein felixfontein mentioned this pull request Apr 26, 2020
Merged
@ansibullbot

This comment has been minimized.

Sign in to view
@felixfontein
Copy link
Collaborator Author

I've prepended a commit which adds version_added: '1.0.0' for all features added after stable-2.9 was branched from ansible/ansible, and before content was moved to collections. This is necessary for having a proper changelog for the ACD 2.10 release which contains all new features, and not just the ones added after the collection split.

(The exact value for version_added is debatable, but modifying the commit is a lot easier than re-creating them from commit history another time.)

@ansibullbot ansibullbot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Apr 26, 2020
@felixfontein felixfontein mentioned this pull request Apr 26, 2020
Merged
@felixfontein felixfontein force-pushed the add-version_added branch 2 times, most recently from af6744e to 3d23baf Compare April 28, 2020 19:53
@felixfontein
Copy link
Collaborator Author

Updated for last commit 599fc7f.

@ansibullbot ansibullbot added the ci_verified Push fixes to PR branch to re-run CI label May 29, 2020
@AlanCoding
Copy link
Contributor

how will version_added for old features be handled? I'm a little confused on that.

@felixfontein
Copy link
Collaborator Author

It won't. Old features were already there in 2.9, so they are not new for community.general, so they don't get/keep a version_added.

@felixfontein felixfontein mentioned this pull request Jun 3, 2020
Closed
5 tasks
@felixfontein
Copy link
Collaborator Author

Updated for last commit a0c5580.

@ansibullbot ansibullbot added has_issue and removed ci_verified Push fixes to PR branch to re-run CI labels Jun 4, 2020
@felixfontein
Copy link
Collaborator Author

Updated for last commit 647abcb.

@felixfontein
Copy link
Collaborator Author

The community working group decided that the next release will be 0.2.0. I will update this PR soon accordingly. (See ansible/community#539 (comment) for details)

@felixfontein
Copy link
Collaborator Author

Updated for last commit 2aa84f0.

@felixfontein felixfontein changed the title [WIP] Add version_added for all new features Add version_added for all new features Jun 13, 2020
@ansibullbot ansibullbot added community_review needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed WIP labels Jun 13, 2020
@felixfontein
Copy link
Collaborator Author

epel still has problems. Since this change should not affect any of the tests, merging. (If it breaks something, I'll fix it later.)

@felixfontein felixfontein merged commit f9589d7 into ansible-collections:master Jun 13, 2020
@felixfontein felixfontein deleted the add-version_added branch June 13, 2020 13:01
@felixfontein felixfontein mentioned this pull request Jun 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andersson007 Andersson007 Andersson007 left review comments

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug has_issue lookup lookup plugin module module needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@felixfontein @ansibullbot @the-maldridge @AlanCoding @gundalow @Andersson007