Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project resource info module #327

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Add project resource info module #327

merged 2 commits into from
Dec 12, 2023

Conversation

raman-babich
Copy link
Contributor

SUMMARY

Fixes #323

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

project resource info module

@raman-babich
Copy link
Contributor Author

@mamercad as I can see you had some commits to the repository some time ago, is there any way to merge my contributions? BTW I also want to provide prs for some other issues of this repo.

@mamercad
Copy link
Collaborator

mamercad commented Dec 5, 2023

@mamercad as I can see you had some commits to the repository some time ago, is there any way to merge my contributions? BTW I also want to provide prs for some other issues of this repo.

@mamercad as I can see you had some commits to the repository some time ago, is there any way to merge my contributions? BTW I also want to provide prs for some other issues of this repo.

Sure, mind getting the tests passing?

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (b5290f8) 64.49% compared to head (9c47da2) 30.78%.
Report is 1 commits behind head on main.

Files Patch % Lines
...ins/modules/digital_ocean_project_resource_info.py 56.00% 11 Missing ⚠️
plugins/module_utils/digital_ocean.py 28.57% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #327       +/-   ##
===========================================
- Coverage   64.49%   30.78%   -33.71%     
===========================================
  Files           4       46       +42     
  Lines         414     3602     +3188     
  Branches       82      738      +656     
===========================================
+ Hits          267     1109      +842     
- Misses        125     2473     +2348     
+ Partials       22       20        -2     
Flag Coverage Δ
sanity 26.12% <54.34%> (?)
units 62.35% <28.57%> (-2.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raman-babich
Copy link
Contributor Author

I think the tests should be green now.

@raman-babich
Copy link
Contributor Author

Sorry, pylint on my local machine could not find these issues. I force-pushed a fix.

@mamercad
Copy link
Collaborator

mamercad commented Dec 8, 2023

Thanks for working on this, mind adding a changelog fragment?

@raman-babich
Copy link
Contributor Author

Don't know if it is everything that I should mention in it, but I have added it.

Copy link
Collaborator

@mamercad mamercad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@mamercad mamercad merged commit 5b66a23 into ansible-collections:main Dec 12, 2023
9 of 10 checks passed
@raman-babich raman-babich deleted the issues/323-project-resources branch December 16, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module to retrieve project resources
2 participants