Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix handling of FourHundredGigE, and more #1154

Merged
merged 5 commits into from
Jan 30, 2025

Conversation

KB-perByte
Copy link
Collaborator

@KB-perByte KB-perByte commented Jan 22, 2025

SUMMARY

Adding support for short interface names with for c9600 as it supports.

<!--- Describe the change below, including rationale and design decisions -->
fatal: [BATMON]: FAILED! => changed=false
  module_stderr: |-
    interface FourHundredGigabitEthernet
    interface FourHundredGigabitEthernet
                            ^
    % Invalid input detected at '^' marker.

    testAPP(config)#
  module_stdout: ''
  msg: |-
    MODULE FAILURE: No start of json char found
    See stdout/stderr for the exact error

the correct interface names:
FourHundredGigEx/y/zz
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ios/utils.py

ADDITIONAL INFORMATION

The below playbook

    - name: Merge provided configuration with device configuration
      cisco.ios.ios_interfaces:
        config:
          - name: FourHundredGigE1/2/3
            description: Configuration for FourHundredGigE1
            enabled: true
          - name: FourHundredGigabitEthernet1/2/3
            description: Configuration for  FourHundredGigabitEthernet1
            enabled: false
        state: merged
      check_mode: true

Generates -

...
"changed": true,
    "commands": [
        "interface FourHundredGigabitEthernet1/2/3",
        "description Configuration for  FourHundredGigabitEthernet1",
        "shutdown",
        "interface FourHundredGigE1/2/3",
        "description Configuration for FourHundredGigE1",
        "no shutdown"
    ],
    "invocation": {
        "module_args": {
            "config": [
                {
                    "description": "Configuration for FourHundredGigE1",
                    "duplex": null,
                    "enabled": true,
                    "mode": null,
                    "mtu": null,
                    "name": "FourHundredGigE1/2/3",
                    "speed": null,
                    "template": null
                },
                {
                    "description": "Configuration for  FourHundredGigabitEthernet1",
                    "duplex": null,
                    "enabled": false,
                    "mode": null,
                    "mtu": null,
                    "name": "FourHundredGigabitEthernet1/2/3",
                    "speed": null,
                    "template": null
                }
            ],
            "running_config": null,
            "state": "merged"
        }
    }
}

@github-actions github-actions bot added the safe to test For network-integration jobs label Jan 22, 2025
@KB-perByte KB-perByte marked this pull request as draft January 29, 2025 09:52
@KB-perByte KB-perByte marked this pull request as ready for review January 29, 2025 13:17
@KB-perByte KB-perByte changed the title fix handling of FourHundredGigEthernet fix handling of FourHundredGigE, and more Jan 29, 2025
@KB-perByte KB-perByte merged commit a08415b into ansible-collections:main Jan 30, 2025
63 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test For network-integration jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants