Skip to content

Commit

Permalink
fix: circular dependency issues
Browse files Browse the repository at this point in the history
the Ref classes cause a circular depdency issue, i have disabled them in this
commit but it will be inevitable as there are cross references between alarms
and events, the eventual solution will have to be moving Refs into their
own package so each dto can reference it
  • Loading branch information
devraj committed Dec 18, 2023
1 parent a5213b2 commit cdaa0b2
Showing 1 changed file with 19 additions and 19 deletions.
38 changes: 19 additions & 19 deletions gallagher/dto/event.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
IdentityMixin,
)

from ..dto.alarm import AlarmRef
from ..dto.cardholder import CardholderRef
from ..dto.access_group import AccessGroupRef
from ..dto.door import DoorRef
# from ..dto.alarm import AlarmRef
# from ..dto.cardholder import CardholderRef
# from ..dto.access_group import AccessGroupRef
# from ..dto.door import DoorRef


class EventTypeSummary(
Expand Down Expand Up @@ -69,21 +69,21 @@ class EventSummaryResponse(
message: Optional[str]
occurrences: int
priority: int
alarm: AlarmRef

operator: CardholderRef
source: str
group: str
type: str
event_type: EventTypeSummary
division: str
cardholder: str
entry_access_zone: str
exit_access_zone: str
door: DoorRef
access_group: HrefMixin
card: str
modified_item: str
# alarm: AlarmRef

# operator: CardholderRef
# source: str
# group: str
# type: str
# event_type: EventTypeSummary
# division: str
# cardholder: str
# entry_access_zone: str
# exit_access_zone: str
# door: DoorRef
# access_group: HrefMixin
# card: str
# modified_item: str

next: HrefMixin
previous: HrefMixin
Expand Down

0 comments on commit cdaa0b2

Please sign in to comment.