feat: update shield sync indicator layout #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrorezende
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
LGTM, however I'm seeing an error when we already have masp fully synced - it goes back to zero then fills the bar completely. We can address it in a later PR if you want. If this is the case, could you open a new issue?
scrnli_Of4Ap3o8p7q41S.webm
|
Thanks for the review! This is partially correct, because we refetch every time we access the MASP page. But I removed the animation when goes to zero, so it looks less weird 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<Sidebar>componentCloses: #1551
Screen.Recording.2025-01-31.at.18.55.58.mov