feat: shielded rewards intergration #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszjasiuk
requested review from
euharrison,
jurevans,
emccorson and
pedrorezende
mateuszjasiuk
force-pushed
the
feat/shielded-rewards
branch
2 times, most recently
from
fb410c4 to
4794a30
Compare
|
|
mateuszjasiuk
force-pushed
the
feat/shielded-rewards
branch
from
4794a30 to
9153529
Compare
mateuszjasiuk
force-pushed
the
feat/shielded-rewards
branch
from
9153529 to
02b528a
Compare
mateuszjasiuk
force-pushed
the
feat/shielded-rewards
branch
from
d4471c1 to
37de11f
Compare
mateuszjasiuk
force-pushed
the
feat/shielded-rewards
branch
from
0c97e97 to
0d64f9f
Compare
jurevans
approved these changes
Jan 29, 2025
This was referenced Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1371
This integrates the shielded rewards.
The downside is that is seems that the endpoint in namada rpc returns some weird values, so testing might be a bit tricky.How it works for me atm is that if I shield a lot of nam and wait one masp epoch I will see some rewards for one masp epoch, but then it will go back to 0.
You can shield more and repeat the process
Not sure if campfire has nam rewards enabled :/
Also added a function which can simulate rewards for this: