Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builtin anoma-random-next-bytes #3322

Merged
merged 11 commits into from
Feb 18, 2025
Merged

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira commented Feb 10, 2025

The primitive supported on the nock standard library gives random bits, so we need to multiply the argument by 8. Our nock evaluator gives an error if the number of bits is not divisible by 8

@janmasrovira janmasrovira self-assigned this Feb 10, 2025
@janmasrovira janmasrovira force-pushed the fix-name-anoma-random-bits branch 2 times, most recently from d235352 to 00ee4d4 Compare February 14, 2025 15:25
@janmasrovira janmasrovira changed the title Rename builtin anoma-random-next-bytes to anoma-random-next-bits Fix builtin anoma-random-next-bytes Feb 14, 2025
@janmasrovira janmasrovira force-pushed the fix-name-anoma-random-bits branch 2 times, most recently from 7c6293e to de1f708 Compare February 17, 2025 11:37
@janmasrovira janmasrovira marked this pull request as ready for review February 17, 2025 14:14
@janmasrovira janmasrovira force-pushed the fix-name-anoma-random-bits branch from de1f708 to dd85b60 Compare February 17, 2025 14:51
@janmasrovira janmasrovira force-pushed the fix-name-anoma-random-bits branch from dd85b60 to 5c64135 Compare February 17, 2025 22:26
@paulcadman paulcadman added this to the 0.6.10 milestone Feb 18, 2025
@janmasrovira janmasrovira merged commit 9bd5774 into main Feb 18, 2025
4 checks passed
@janmasrovira janmasrovira deleted the fix-name-anoma-random-bits branch February 18, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants