fixed bug in search (.f<g.)

annotation · Nov 17, 2021 · d9218a2 · d9218a2
1 parent 947aa50
commit d9218a2
Show file tree

Hide file tree

Showing 8 changed files with 533 additions and 214 deletions.
diff --git a/dist/text-fabric-9.1.5.tar.gz → dist/text-fabric-9.1.6.tar.gz b/dist/text-fabric-9.1.5.tar.gz → dist/text-fabric-9.1.6.tar.gz
diff --git a/dist/text_fabric-9.1.5-py3-none-any.whl → dist/text_fabric-9.1.6-py3-none-any.whl b/dist/text_fabric-9.1.5-py3-none-any.whl → dist/text_fabric-9.1.6-py3-none-any.whl
diff --git a/setup.py b/setup.py
@@ -40,7 +40,7 @@
             "text-fabric-make = tf.client.make.build:main",
         ]
     },
-    version='9.1.5',
+    version='9.1.6',
     description="""Processor and browser for Text Fabric Data""",
     author="Dirk Roorda",
     author_email="[email protected]",

diff --git a/test/query/featureComparison.ipynb b/test/query/featureComparison.ipynb
diff --git a/text_fabric.egg-info/PKG-INFO b/text_fabric.egg-info/PKG-INFO
@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: text-fabric
-Version: 9.1.5
+Version: 9.1.6
 Summary: Processor and browser for Text Fabric Data
 Home-page: https://github.com/annotation/text-fabric
 Author: Dirk Roorda

diff --git a/tf/docs/about/releases.md b/tf/docs/about/releases.md
@@ -46,6 +46,18 @@ text-fabric appName:hot
 
 ### 9.0
 
+#### 9.1.6
+
+2021-11-17
+
+Bug in search, spotted by Oliver Glanz, with thanks to him for reporting it.
+Queries with `.f<g.` constructs in it (numeric feature comparison)
+delivered wrong results.
+The root cause waas clear: I declared the converse of `.f<g.` to be `.g>f.`.
+But this is not the converse, the two are identical.
+The converse is `.f>g.`.
+See [code](https://github.com/annotation/text-fabric/blob/947aa5071d545ed5c875fe24eeb7329d4a8e9893/tf/search/relations.py#L1450-L1457)
+
 #### 9.1.5
 
 2021-11-17

diff --git a/tf/parameters.py b/tf/parameters.py
@@ -8,7 +8,7 @@
 from zipfile import ZIP_DEFLATED
 
 
-VERSION = '9.1.5'
+VERSION = '9.1.6'
 """Program version.
 
 This value is under control of the update process, as run by

diff --git a/tf/search/relations.py b/tf/search/relations.py
@@ -1449,11 +1449,11 @@ def edgeSR(fTp, tTp):
         ),
         (
             (".f>g.", 0.4, leftFgreaterRightGR, "left.f > right.g"),
-            (".g<f.", 0.4, leftGlesserRightFR, None),
+            (".f<g.", 0.4, leftFlesserRightGR, None),
         ),
         (
-            (".f<g.", 0.4, leftFlesserRightGR, "left.f > right.g"),
-            (".g>f.", 0.4, leftGgreaterRightFR, None),
+            (".f<g.", 0.4, leftFlesserRightGR, "left.f < right.g"),
+            (".f>g.", 0.4, leftFgreaterRightGR, None),
         ),
     ]