-
Notifications
You must be signed in to change notification settings - Fork 4
Fixes #1035: Add black and flake8 as pre-commit hook #1058
base: develop
Are you sure you want to change the base?
Conversation
@BALaka-18 Codewise LGTM! Can you please add the screenshot by runing this pre-commit hook on your local? |
Yes sure. |
@Kajol-Kumari I have attached the screenshots. |
Hey @BALaka-18 can we please add a check to insure that users install the pre-commit hook. Otherwise don't allow them to commit (reject the commit). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from a first look, can you post the diff of requirements.txt
, I can't seem to see it in the view for some reason
@SanketDG I had removed the older versions of six and PyYAML, else the build was running into errors. |
@Kajol-Kumari I have added the check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BALaka-18 Minor changes required :)
- Add a ss of
requirements.txt
file in issue description. - Incorporate the suggested change.
Hey @BALaka-18 If I am not wrong, you have just pasted the ss of the changes You have done in |
@Kajol-Kumari these are the extra dependencies required to make the pre-commit hook run. The rest of the dependencies are the same as in the current requirements.txt file. So I passed only the new dependencies needed and not the whole file. Should I upload the ss for the whole file ? |
Thanks for confirming @BALaka-18. No, you don't need to attach the ss of the whole file here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Hi @Kajol-Kumari, is this PR ready to be merged ? |
@BALaka-18 please squash all the commits into a single commit so that it can be send for final approval. |
100dbb0
to
300a396
Compare
@Kajol-Kumari done ! |
Description
This PR adds the code formatting tools, black and flake8, as pre-commit hook to ensure the code is organized and well formatted.
Fixes #1035
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
Screenshots:
requirements.txt :
Checklist:
Code/Quality Assurance Only