fix guided tour for variable/value aes (named clickSelects/showSelected) #182
+205
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdhock
changed the title
|
this PR also adds an argument to animint2pages, chromote_sleep_seconds=NULL (new default) means to not try to do auto screen capture, which seems to not be working... > animint2pages(wb.facets, "2025-01-WorldBank-facets-map")
Le chargement a nécessité le package : gert
Le chargement a nécessité le package : gh
Le chargement a nécessité le package : chromote
Le chargement a nécessité le package : magick
Le chargement a nécessité le package : grDevices
Serving the directory /tmp/RtmpXQyylH/file92db27ba9c98 at http://127.0.0.1:4025
Erreur : R: geometry does not contain image `/tmp/RtmpXQyylH/file92db27ba9c98/Capture_full.PNG' @ warning/attribute.c/GetImageBoundingBox/519 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR improves the DriverJS functionality.
Before this PR the DriverJS description did not include selector names, for named clickSelects/showSelected.
This PR changes the compiler to add help_clickSelects and help_showSelected parameters to each geom in the plot.json, which include the selector names, taken from the data values in the case of named clickSelects/showSelected.