theme_animint(rowspan, colspan, last_in_row) #153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #115
this proposal supersedes #139 which should be closed if this PR is sufficient.
The idea is to define three new plot attributes, to be specified inside
theme_animint
rowspan=2
means plot takes up two rows (default=1)colspan=2
means plot takes up two columns (default=1)last_in_row=TRUE
means this plot ends a row, HTML<tr>
element. (default=FALSE)the R code compiler needs to save these as attributes of the corresponding plot list.
For example
should make HTML like below
if any of these three attributes are specified in any of the ggplots, then the renderer JavaScript code puts the plot in the corresponding tr and td of the "outer table," according to the following rules:
<tr>
before the first plot, and after every plot withlast_in_row=TRUE
<td>
inside the current<tr>
There is no need for computing the total/max number of rows/columns.
@siddhesh195 please consider this PR and if you agree, close the other PR, and move any relevant code to this branch (compiler R code, tests, etc).