Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WorldBank test #121

Closed
wants to merge 1 commit into from
Closed

Add WorldBank test #121

wants to merge 1 commit into from

Conversation

nhintruong
Copy link

Adding WorldBank for the hard test in GSOC 2024 application

@tdhock
Copy link
Collaborator

tdhock commented Apr 2, 2024

great thanks for the contribution!
Can you please clarify if your new code tests any functionality which is not already covered in the other tests?

@nhintruong
Copy link
Author

This is a testthat unit test based on one of my Animint visualizations, as requested in the hard test section here. I don't think there is any new functionality being tested. Please let me know if you would like me to do so.

@tdhock
Copy link
Collaborator

tdhock commented Apr 2, 2024

it would be good if you could check code coverage, and see if you could add a test that increases coverage.
this could be added to GSOC goals (computing coverage for R code on Github actions should be easy, would be nice if we could compute javascript coverage too)

@nhintruong
Copy link
Author

Yes, I can do that. Should I add this to the test section in the proposal, or in one of the goals of the project?

@tdhock
Copy link
Collaborator

tdhock commented Apr 2, 2024

sure, you can add it to tests and goals
continue discussion about code coverage #122

@tdhock tdhock closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants