Skip to content

Commit

Permalink
30e6760 fix(core): Fix a bug where snapshotted functions are being ru…
Browse files Browse the repository at this point in the history
…n twice if they return a nullish/falsey value. (#59073)
  • Loading branch information
alxhub committed Dec 6, 2024
1 parent cd947c9 commit fde3dc3
Show file tree
Hide file tree
Showing 10 changed files with 95 additions and 100 deletions.
4 changes: 2 additions & 2 deletions BUILD_INFO
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Thu Dec 5 23:30:07 UTC 2024
87803992346dde0189fd40b486f256847d458969
Fri Dec 6 00:25:00 UTC 2024
30e676098d72e9e11a6628b9716668df08f18c62
148 changes: 72 additions & 76 deletions fesm2022/router.mjs

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion fesm2022/router.mjs.map

Large diffs are not rendered by default.

23 changes: 11 additions & 12 deletions fesm2022/testing.mjs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @license Angular v19.1.0-next.2+sha-8780399
* @license Angular v19.1.0-next.2+sha-30e6760
* (c) 2010-2024 Google LLC. https://angular.io/
* License: MIT
*/
Expand Down Expand Up @@ -59,16 +59,16 @@ class RouterTestingModule {
],
};
}
static ɵfac = i0.ɵɵngDeclareFactory({ minVersion: "12.0.0", version: "19.1.0-next.2+sha-8780399", ngImport: i0, type: RouterTestingModule, deps: [], target: i0.ɵɵFactoryTarget.NgModule });
static ɵmod = i0.ɵɵngDeclareNgModule({ minVersion: "14.0.0", version: "19.1.0-next.2+sha-8780399", ngImport: i0, type: RouterTestingModule, exports: [RouterModule] });
static ɵinj = i0.ɵɵngDeclareInjector({ minVersion: "12.0.0", version: "19.1.0-next.2+sha-8780399", ngImport: i0, type: RouterTestingModule, providers: [
static ɵfac = i0.ɵɵngDeclareFactory({ minVersion: "12.0.0", version: "19.1.0-next.2+sha-30e6760", ngImport: i0, type: RouterTestingModule, deps: [], target: i0.ɵɵFactoryTarget.NgModule });
static ɵmod = i0.ɵɵngDeclareNgModule({ minVersion: "14.0.0", version: "19.1.0-next.2+sha-30e6760", ngImport: i0, type: RouterTestingModule, exports: [RouterModule] });
static ɵinj = i0.ɵɵngDeclareInjector({ minVersion: "12.0.0", version: "19.1.0-next.2+sha-30e6760", ngImport: i0, type: RouterTestingModule, providers: [
ɵROUTER_PROVIDERS,
provideLocationMocks(),
withPreloading(NoPreloading).ɵproviders,
{ provide: ROUTES, multi: true, useValue: [] },
], imports: [RouterModule] });
}
i0.ɵɵngDeclareClassMetadata({ minVersion: "12.0.0", version: "19.1.0-next.2+sha-8780399", ngImport: i0, type: RouterTestingModule, decorators: [{
i0.ɵɵngDeclareClassMetadata({ minVersion: "12.0.0", version: "19.1.0-next.2+sha-30e6760", ngImport: i0, type: RouterTestingModule, decorators: [{
type: NgModule,
args: [{
exports: [RouterModule],
Expand Down Expand Up @@ -99,23 +99,22 @@ class RootFixtureService {
this.fixture.detectChanges();
return this.fixture;
}
static ɵfac = i0.ɵɵngDeclareFactory({ minVersion: "12.0.0", version: "19.1.0-next.2+sha-8780399", ngImport: i0, type: RootFixtureService, deps: [], target: i0.ɵɵFactoryTarget.Injectable });
static ɵprov = i0.ɵɵngDeclareInjectable({ minVersion: "12.0.0", version: "19.1.0-next.2+sha-8780399", ngImport: i0, type: RootFixtureService, providedIn: 'root' });
static ɵfac = i0.ɵɵngDeclareFactory({ minVersion: "12.0.0", version: "19.1.0-next.2+sha-30e6760", ngImport: i0, type: RootFixtureService, deps: [], target: i0.ɵɵFactoryTarget.Injectable });
static ɵprov = i0.ɵɵngDeclareInjectable({ minVersion: "12.0.0", version: "19.1.0-next.2+sha-30e6760", ngImport: i0, type: RootFixtureService, providedIn: 'root' });
}
i0.ɵɵngDeclareClassMetadata({ minVersion: "12.0.0", version: "19.1.0-next.2+sha-8780399", ngImport: i0, type: RootFixtureService, decorators: [{
i0.ɵɵngDeclareClassMetadata({ minVersion: "12.0.0", version: "19.1.0-next.2+sha-30e6760", ngImport: i0, type: RootFixtureService, decorators: [{
type: Injectable,
args: [{ providedIn: 'root' }]
}] });
class RootCmp {
outlet;
routerOutletData = signal(undefined);
static ɵfac = i0.ɵɵngDeclareFactory({ minVersion: "12.0.0", version: "19.1.0-next.2+sha-8780399", ngImport: i0, type: RootCmp, deps: [], target: i0.ɵɵFactoryTarget.Component });
static ɵcmp = i0.ɵɵngDeclareComponent({ minVersion: "14.0.0", version: "19.1.0-next.2+sha-8780399", type: RootCmp, isStandalone: true, selector: "ng-component", viewQueries: [{ propertyName: "outlet", first: true, predicate: RouterOutlet, descendants: true }], ngImport: i0, template: '<router-outlet [routerOutletData]="routerOutletData()"></router-outlet>', isInline: true, dependencies: [{ kind: "directive", type: RouterOutlet, selector: "router-outlet", inputs: ["name", "routerOutletData"], outputs: ["activate", "deactivate", "attach", "detach"], exportAs: ["outlet"] }] });
static ɵfac = i0.ɵɵngDeclareFactory({ minVersion: "12.0.0", version: "19.1.0-next.2+sha-30e6760", ngImport: i0, type: RootCmp, deps: [], target: i0.ɵɵFactoryTarget.Component });
static ɵcmp = i0.ɵɵngDeclareComponent({ minVersion: "14.0.0", version: "19.1.0-next.2+sha-30e6760", type: RootCmp, isStandalone: true, selector: "ng-component", viewQueries: [{ propertyName: "outlet", first: true, predicate: RouterOutlet, descendants: true }], ngImport: i0, template: '<router-outlet [routerOutletData]="routerOutletData()"></router-outlet>', isInline: true, dependencies: [{ kind: "directive", type: RouterOutlet, selector: "router-outlet", inputs: ["name", "routerOutletData"], outputs: ["activate", "deactivate", "attach", "detach"], exportAs: ["outlet"] }] });
}
i0.ɵɵngDeclareClassMetadata({ minVersion: "12.0.0", version: "19.1.0-next.2+sha-8780399", ngImport: i0, type: RootCmp, decorators: [{
i0.ɵɵngDeclareClassMetadata({ minVersion: "12.0.0", version: "19.1.0-next.2+sha-30e6760", ngImport: i0, type: RootCmp, decorators: [{
type: Component,
args: [{
standalone: true,
template: '<router-outlet [routerOutletData]="routerOutletData()"></router-outlet>',
imports: [RouterOutlet],
}]
Expand Down
2 changes: 1 addition & 1 deletion fesm2022/testing.mjs.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion fesm2022/upgrade.mjs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @license Angular v19.1.0-next.2+sha-8780399
* @license Angular v19.1.0-next.2+sha-30e6760
* (c) 2010-2024 Google LLC. https://angular.io/
* License: MIT
*/
Expand Down
2 changes: 1 addition & 1 deletion index.d.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @license Angular v19.1.0-next.2+sha-8780399
* @license Angular v19.1.0-next.2+sha-30e6760
* (c) 2010-2024 Google LLC. https://angular.io/
* License: MIT
*/
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@angular/router",
"version": "19.1.0-next.2+sha-8780399",
"version": "19.1.0-next.2+sha-30e6760",
"description": "Angular - the routing library",
"keywords": [
"angular",
Expand All @@ -24,9 +24,9 @@
"tslib": "^2.3.0"
},
"peerDependencies": {
"@angular/core": "19.1.0-next.2+sha-8780399",
"@angular/common": "19.1.0-next.2+sha-8780399",
"@angular/platform-browser": "19.1.0-next.2+sha-8780399",
"@angular/core": "19.1.0-next.2+sha-30e6760",
"@angular/common": "19.1.0-next.2+sha-30e6760",
"@angular/platform-browser": "19.1.0-next.2+sha-30e6760",
"rxjs": "^6.5.3 || ^7.4.0"
},
"ng-update": {
Expand Down
2 changes: 1 addition & 1 deletion testing/index.d.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @license Angular v19.1.0-next.2+sha-8780399
* @license Angular v19.1.0-next.2+sha-30e6760
* (c) 2010-2024 Google LLC. https://angular.io/
* License: MIT
*/
Expand Down
2 changes: 1 addition & 1 deletion upgrade/index.d.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @license Angular v19.1.0-next.2+sha-8780399
* @license Angular v19.1.0-next.2+sha-30e6760
* (c) 2010-2024 Google LLC. https://angular.io/
* License: MIT
*/
Expand Down

0 comments on commit fde3dc3

Please sign in to comment.