Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-luxon-adapter): infer first day of week from locale #30285

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix(material-luxon-adapter): infer first day of week from locale #30285

merged 1 commit into from
Jan 9, 2025

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 8, 2025

Fixes that the Luxon date adapter was hardcoding the first day of the week to Sunday, unless it's provided through DI.

Fixes #30278.

@crisbeto
fix(material-luxon-adapter): infer first day of week from locale
2564ac8 
Fixes that the Luxon date adapter was hardcoding the first day of the week to Sunday, unless it's provided through DI.

Fixes angular#30278.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jan 8, 2025
@crisbeto crisbeto requested a review from a team as a code owner January 8, 2025 09:03
@crisbeto crisbeto requested review from mmalerba and wagnermaciel and removed request for a team January 8, 2025 09:03
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jan 9, 2025
@crisbeto crisbeto merged commit 659e5d4 into angular:main Jan 9, 2025
21 of 23 checks passed
crisbeto added a commit that referenced this pull request Jan 9, 2025
@crisbeto
fix(material-luxon-adapter): infer first day of week from locale (#30285
e52a369 
)

Fixes that the Luxon date adapter was hardcoding the first day of the week to Sunday, unless it's provided through DI.

Fixes #30278.

(cherry picked from commit 659e5d4)
crisbeto added a commit that referenced this pull request Jan 9, 2025
@crisbeto
fix(material-luxon-adapter): infer first day of week from locale (#30285
97d61e0 
)

Fixes that the Luxon date adapter was hardcoding the first day of the week to Sunday, unless it's provided through DI.

Fixes #30278.

(cherry picked from commit 659e5d4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(datepicker): Luxon date adapter consider by default Sunday as the first day of week for any locale
2 participants
@crisbeto @andrewseguin