Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TLS for mongo without sharding #201

Merged
merged 1 commit into from
Jan 24, 2025
Merged

fix: TLS for mongo without sharding #201

merged 1 commit into from
Jan 24, 2025

Conversation

aneojgurhem
Copy link
Contributor

@aneojgurhem aneojgurhem commented Jan 24, 2025

Motivation

Allow ArmoniK.Core version 0.30.0 to connect to mongodb (not sharded) with TLS.

Description

Add an extra namespace in the Helm Chart. It then produces certificates with the dns we use to connect to mongodb. It allows to connect with TLS without issues.

Testing

  • Test on local and AWS deployment were performed with ArmoniK, this version of the infrastructure and ArmoniK.Core version 0.30.0. Bench execution passes without issues.

Impact

Allow to use regular mongodb with the new core version.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

@aneojgurhem aneojgurhem self-assigned this Jan 24, 2025
@aneojgurhem aneojgurhem merged commit 994abc2 into main Jan 24, 2025
5 checks passed
@aneojgurhem aneojgurhem deleted the jg/tlsmongo branch January 24, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants