feat: Added SQS support to ArmoniK.Infra #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AncientPatata
force-pushed
the
ad/sqs_support
branch
2 times, most recently
from
eae7872 to
85edf38
Compare
AncientPatata
changed the title
AncientPatata
force-pushed
the
ad/sqs_support
branch
2 times, most recently
from
294b551 to
cf7fbf7
Compare
AncientPatata
force-pushed
the
ad/sqs_support
branch
9 times, most recently
from
476b1df to
fcd30b4
Compare
AncientPatata
force-pushed
the
ad/sqs_support
branch
7 times, most recently
from
7f35f1d to
2ea9d7a
Compare
AncientPatata
force-pushed
the
ad/sqs_support
branch
2 times, most recently
from
096b190 to
f315cec
Compare
AncientPatata
force-pushed
the
ad/sqs_support
branch
3 times, most recently
from
be58002 to
7e64d2a
Compare
AncientPatata
force-pushed
the
ad/sqs_support
branch
3 times, most recently
from
dbfee09 to
11b0f03
Compare
AncientPatata
force-pushed
the
ad/sqs_support
branch
from
11b0f03 to
286452e
Compare
ngruelaneo
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
SQS was added to ArmoniK.Core but was never supported in ArmoniK.Infra.
Description
Added an optional kubernetes service account that can be associated with an AWS role that has access to SQS queues, and exported certain environment variables for ArmoniK.Core to access.
Testing
Manually tested through deployments.
Impact
A bit intrusive in terms of ArmoniK's configuration (
parameters.tfvars) because of the use of a service account.Additional Information
None.
Checklist