Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added support for sort and page options to sessions' list command #33

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

AncientPatata
Copy link
Contributor

Motivation

Session's list command didn't have support for the sort and page options.

Description

Added support for --sort-* and --page* options to the sessions' list command.

Testing

  • Tested sorting locally.
  • Unit tests pass.

Impact

Would impact the documentation if it existed.

Additional Information

None.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
628 574 91% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 39de881 by action🐍

@qdelamea-aneo qdelamea-aneo merged commit 691a8ec into main Jan 16, 2025
4 checks passed
@qdelamea-aneo qdelamea-aneo deleted the ad/sessions_filtering branch January 16, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants