Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: changed names of functions to avoid overriding builtins #32

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

AncientPatata
Copy link
Contributor

Motivation

Adopted a new standard where functions implementing command command are prefixed by the group (group_command) to avoid overriding Python's builtin functions (such as "list" or "set") as that can cause unexpected behavior.

Description

  • Changed the names of the different functions
  • Changed condition on Tasks list command

Testing

Code refactor, all tests still pass.

Impact

Have to reinforce the naming standard.

Additional Information

None.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

Copy link

github-actions bot commented Jan 16, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
616 563 91% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 2cb06b1 by action🐍

@AncientPatata AncientPatata force-pushed the ad/rename_commands_convention branch from 77c5a57 to 2edf5b3 Compare January 16, 2025 15:09
@AncientPatata AncientPatata force-pushed the ad/rename_commands_convention branch from 2edf5b3 to 2cb06b1 Compare January 16, 2025 15:10
@qdelamea-aneo qdelamea-aneo merged commit bd442b0 into main Jan 16, 2025
4 checks passed
@qdelamea-aneo qdelamea-aneo deleted the ad/rename_commands_convention branch January 16, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants