Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort-by option for partition list command #31

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

AncientPatata
Copy link
Contributor

Motivation

Sorting would fail on using --sort-by because it would expect Task attributes.

Description

Changed the FieldParam parameter.

Testing

Command run succeeds, tested locally.

Impact

Not applicable.

Additional Information

None.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
616 563 91% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 55cd622 by action🐍

@qdelamea-aneo qdelamea-aneo changed the title fix: Changed the FieldParam from Task to Partition fix: sort-by option for partition list command Jan 16, 2025
@qdelamea-aneo qdelamea-aneo merged commit b00638f into main Jan 16, 2025
4 checks passed
@qdelamea-aneo qdelamea-aneo deleted the ad/fix_partition_param branch January 16, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants