fix: Error handler always prints out the error message when available else the traceback #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
the error_handler captures and obfuscates errors unless
--debug
is passed.Description
This PR makes it so it spits out the error message instead of "Internal Error" when said message exists (for gRPC for instance), and in the other case of a generic exception, it always prints the exception with the traceback which might make it easier for the user to understand what went wrong (Basically the behavior of passing in
--debug
in this case. Click continues to handle its own exceptions.Testing
Not applicable.
Impact
Not applicable.
Additional Information
Not applicable.
Checklist