Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error handler always prints out the error message when available else the traceback #29

Closed
wants to merge 1 commit into from

Conversation

AncientPatata
Copy link
Contributor

Motivation

the error_handler captures and obfuscates errors unless --debug is passed.

Description

This PR makes it so it spits out the error message instead of "Internal Error" when said message exists (for gRPC for instance), and in the other case of a generic exception, it always prints the exception with the traceback which might make it easier for the user to understand what went wrong (Basically the behavior of passing in --debug in this case. Click continues to handle its own exceptions.

Testing

Not applicable.

Impact

Not applicable.

Additional Information

Not applicable.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant